Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [RESEND] brcmfmac support for BCM4359 sdio on arm64 ??
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <37d2964d-1c2b-51bd-ac98-2cc171aa0c9c@broadcom.com>
Date:   Mon, 24 Jun 2019 19:45:41 +0400
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, Wright.Feng@cypress.com,
        Neil Armstrong <narmstrong@baylibre.com>,
        Christoph Muellner <christoph.muellner@theobroma-systems.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <30516339-BAD7-40F4-980B-D30CDF504A08@gmail.com>
References: <F5C2858A-498E-4AD3-859D-FA9D14BF6B37@gmail.com>
 <37d2964d-1c2b-51bd-ac98-2cc171aa0c9c@broadcom.com>
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 11 Jun 2019, at 1:45 pm, Arend Van Spriel =
<arend.vanspriel@broadcom.com> wrote:
>=20
> The splat could be relevant. Maybe try the patch below to get actual =
values that are checked in the WARN_ON.
>=20
>> BCMDHD is also reported working with commits here: =
https://gitlab.com/baylibre/amlogic/atv/linux/commits/narmstrong/v5.1/aml/=
integ-5.1-bcmdhd but LibreELEC needs to support many different boards =
(with many different SDIO modules) from a single OS image, so BCMDHD is =
not the solution we need.
>> One additional patch I spotted mentioning BCM4359 (also from Wright =
Feng) was =
https://github.com/RobertCNelson/ti-linux-kernel-dev/blob/65f17112e1c883d3=
c9f3fa68837e5f9b5eb7cfad/patches/cypress/v4.14.52-2018_0928/cypress-patch/=
0073-non-upstream-reset-two-D11-cores-if-chip-has-two-D11.patch but it =
makes no difference (the dmesg log above is with this patch applied).
>> I don=E2=80=99t write code but am happy to build test kernels with =
suggested patches or explicit instructions. I=E2=80=99ve also CC=E2=80=99d=
 LibreELEC colleague and linux-amlogic maintainer Neil Armstrong who can =
assist. NB: If direct access to hardware would help progress things I =
can easily organise remote access or get board samples shipped.
>> How can we resume the investigation?
>=20
> Let's try one step at a time ;-)
>=20
> Regards,
> Arend
> ---
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c =
b/driver
> index fc12598..e9b0986 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -772,7 +772,8 @@ void brcmf_sdiod_sgtable_alloc(struct =
brcmf_sdio_dev *sdiod
>                      sdiodev->settings->bus.sdio.txglomsz);
>        nents +=3D (nents >> 4) + 1;
>=20
> -       WARN_ON(nents > sdiodev->max_segment_count);
> +       WARN(nents > sdiodev->max_segment_count, "max_seg_cnt=3D%u, =
host_max_seg=3D
> +            sdiodev->max_segment_count, host->max_segs, nents);
>=20
>        brcmf_dbg(TRACE, "nents=3D%d\n", nents);
>        err =3D sg_alloc_table(&sdiodev->sgtable, nents, GFP_KERNEL);
> q

^ this patch is mangled - please send me the correct one so I can reply =
with information to move things forwards. Thanks.

Christian=