Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3319191ybd; Tue, 25 Jun 2019 00:08:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkAg4viffo2g1deeIvjvoXIUaDWz1sI6/rdeLM5Oo3vBm6PynvSi1XPIIwejeStozfMSoo X-Received: by 2002:a17:902:bb90:: with SMTP id m16mr81661322pls.54.1561446491301; Tue, 25 Jun 2019 00:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561446491; cv=none; d=google.com; s=arc-20160816; b=U+Enz6umxwb57SaJueH+22rqGWuHvc8axB7iLev3mLRxk8HX4uzwzHaCmQ8icrlsC3 H0g833ozeCuIlrGPfsVar13Wlg2IbQAw3YSgv0yVM9Ej41wS12zeCoRocEI6ydhGx4ny VtlNlSje4CEzsPyGoIV5v2yaMoROi/M5mknWUwf2/dKLPHVxgKa0J6C9UfJb2ULOvINx mvy9sMGH+hkRDs8Go5P6/ch+zgar+rOncUAGIlI/Y6rgEY9++ZVQ4SY72ARu27pAK3TB yWKQWXEWbZ4ZMilrLGWT2249YhIooOcs4olfE0juOQ+LYy+m+3AcGYiG7QcUgBn3vGXm 6ovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=x/P7r1idRSNdPxPMU0zl2ptqMsgniU7O5WxdquSf+oA=; b=H7DcyV9MqY+ISSN+QKgzgnnrDayVCrC6McdPBYswTRgb5f8C3ihBrc1QH7900vr1w0 eyz1rrLFbFcT1kKLFHuwmFV6/QKiXKSfQJAgVk0hPsBNLuPRkF6oJsoFN5bN69RkBil7 uVSHQUT1q5CT5OhCDqYhFq7wSj4p9UiyXGELV/OTMpFzrcu1W4W8RBNqd7ADlwzQLrGw 3Ea/qm+28kLinNLakv2Gtt4mtMFbO2jIgMGTP5kCriMcF3vZmAoLgqR3w/KZxzO+niPJ DII67TdxZNr3fMc2goJgjpn+ZFghm0kZdi5j6G2L97oJ9ORs7jpcgECttvtFngNHeQYn xvsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lEI1dLVV; dkim=pass header.i=@codeaurora.org header.s=default header.b=eyBuRVJN; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si1885941pjr.47.2019.06.25.00.07.56; Tue, 25 Jun 2019 00:08:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lEI1dLVV; dkim=pass header.i=@codeaurora.org header.s=default header.b=eyBuRVJN; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbfFYExP (ORCPT + 99 others); Tue, 25 Jun 2019 00:53:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55502 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbfFYExP (ORCPT ); Tue, 25 Jun 2019 00:53:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5747960867; Tue, 25 Jun 2019 04:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561438394; bh=0PTm5aueCleXr3/4IPxcFUoSNh6YuLWUu+js7/+jTuo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=lEI1dLVV5amFS/Y/IJouk/tt4O7DePXPbSeIBOr9TqRZpSUCzDvab4rmpnBy4T5b0 IOLXtt+cK4aV80/PckOi1DQo+XvQS2wwy1K4TCT+aazXr4zbOl+JUNeRuwmQqTz6xy CDUctqZ62Wp5LbvQaxjLB3fBDh4WP6cOupSzPKwY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id ECAEA6070D; Tue, 25 Jun 2019 04:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561438393; bh=0PTm5aueCleXr3/4IPxcFUoSNh6YuLWUu+js7/+jTuo=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=eyBuRVJNO9GWfnLXo5WrtNFrK2GXZE7GsX0nhCqAVZYHX/s17lGhVsWZf3fhArQtp u79JxcnmZt8raszudab99oUtKtSAKYkEXJ2DrktEW7DMFdRYjxu6m7R+m07MIoFy1w uBHK4OTO8xSckFfzPqe8JIaA9/MXsZGFKCWrs3bI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ECAEA6070D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mwifiex: ignore processing invalid command response From: Kalle Valo In-Reply-To: <1561126484-7735-1-git-send-email-gbhat@marvell.com> References: <1561126484-7735-1-git-send-email-gbhat@marvell.com> To: Ganapathi Bhat Cc: , Brian Norris , Cathy Luo , Zhiyuan Yang , James Cao , "Rakesh Parmar" , Swati Kushwaha , Ganapathi Bhat User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190625045314.5747960867@smtp.codeaurora.org> Date: Tue, 25 Jun 2019 04:53:14 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ganapathi Bhat wrote: > From: Swati Kushwaha > > Firmware can send invalid command response, the processing of > which can attempt to modify unexpected context and cause issues. > To fix this, driver should check that the command response ID is > same as the one it downloaded, and ignore processing of invalid > response. > > Signed-off-by: Swati Kushwaha > Signed-off-by: Ganapathi Bhat Patch applied to wireless-drivers-next.git, thanks. 74f202aaae0a mwifiex: ignore processing invalid command response -- https://patchwork.kernel.org/patch/11010163/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches