Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] iwlwifi: Extended Key ID support
To:     johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org, luca@coelho.fi
References: <20190506190149.3624-1-alexander@wetzel-home.de>
 <20190506190149.3624-2-alexander@wetzel-home.de>
From:   Alexander Wetzel <alexander@wetzel-home.de>
Message-ID: <7a173bac-37d2-b470-8cb6-0f7e41e26ca5@wetzel-home.de>
Date:   Wed, 26 Jun 2019 23:10:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <20190506190149.3624-2-alexander@wetzel-home.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> iwlwifi cards are all able to support Extended Key ID as long as
> mac80211 stops A-MPDU aggregation when replacing the unicast key.
> 
> Enable Extended Key ID support and tell mac80211 that it has to tear
> down any running Tx aggregation sessions during rekey when using
> Extended Key ID.

With the merge of the A-MPDU handling patch 
https://patchwork.kernel.org/patch/10931861/ we probably should simplify 
the API for Extended Key ID and not merge the patch as it is:

1) We can drop EXT_KEY_ID_NATIVE from mac80211 and let the drivers set
    NL80211_EXT_FEATURE_EXT_KEY_ID instead of mac80211.
    Without the COMPAT support the naming is off and the flag is simply
    pointless. Assuming we want to pick up the COMPAT Extended Key ID we
    still can just define a new flag, e.g.
    SINGLE_STA_UNICAST_KEY_OFFLOAD_ONLY to tell mac80211 it can only
    have one unicast key active in the HW per STA.

2) Mac80211 would then enable Extended Key ID for all drivers using SW
    crypto and just also set NO_AMPDU_KEYBORDER_SUPPORT when the driver
    supports A-MPDU

3) we then could undo (revert?) cfe7007a9b4c ("mac80211_hwsim: Extended
    Key ID support") and let the more generic code in mac80211 handle it

If you agree I'll prepare and test a small patch series for that.
And we better only merge a iteration of this patch here once we got the 
API updated.

Alexander