Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2345238ybd; Thu, 27 Jun 2019 10:49:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyd4DKXvPLHXlBSXXkzExBB1WOck4pIBnqkA/JEgc0N39ZfiQyUtwfBZASCMZGFx8oG/dh7 X-Received: by 2002:a17:90a:71ca:: with SMTP id m10mr7578862pjs.27.1561657765610; Thu, 27 Jun 2019 10:49:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561657765; cv=none; d=google.com; s=arc-20160816; b=qoiLSIg4mX+j49Ug5nWNiDVau4PdLSWfguAZNO430gHX75t2nbSwQPUcm6qhISPodo czbdeiTEzUSoN7rUVIi0WP89gt0OWVW9Pdeu9Aze1di5fceFLmK3Zsfa7lZxkT+mcq2L JCzqIW62xZ+ReaAwzs+jSa+IcbxvBRhxjVAe7RCZhXuNRgenQYeV59tqyGhifbQ9w06E irgrlujfwsm6nDyVCOLvCUc50B/lmt6pTSNMRxT3rvw0nSpyRWwdKvGVHsBkJLZ8c8P1 +axldKWY3U/jJYhEB3w1YOjJdCrqwXQgbvTvKPVPRBttqSy6ZopOzCplYTRq/eIXsme7 Ky6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=fukNgQPRH57+MDtzhetM5CtZUDEWJ3RXNZ9FQabKArs=; b=nTu1LPaOY021PZHbwq71x5Mn4nu+/7fxQZBS9+r9cl80o01tDgbBhwq95oYEoLjp6g eRJB1g1SYo2MkWMkrFn2A2zO7gSsHEOTjLFTBdqXAZMwUl900EioMMDDdEpQiQfu5vfq CWF60JGuLlZcD6QWeSROgiN6QeD6qY3+ADM1PoBryMJZilO7nMFSc/CNQAkkPd9I6ZiC RToPGw7B9j9KD2rsbOkcLRdo/18QkGO3MBnBxMN/bUFHWC3DEvWxTioAVqfod9LNNgaH N6m/nywX9QdcJ//DmuGacDC9kQ3nynjhexqQSoszrxNDiRbmHaJr4hIciODxGaIZMKtT 5XPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=fjTjMoIJ; dkim=pass header.i=@codeaurora.org header.s=default header.b=SKoCozRh; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u62si106961pjb.3.2019.06.27.10.49.11; Thu, 27 Jun 2019 10:49:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=fjTjMoIJ; dkim=pass header.i=@codeaurora.org header.s=default header.b=SKoCozRh; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbfF0RsF (ORCPT + 99 others); Thu, 27 Jun 2019 13:48:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53420 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726557AbfF0RsE (ORCPT ); Thu, 27 Jun 2019 13:48:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 669DB60AA8; Thu, 27 Jun 2019 17:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561657684; bh=FC/fnWQl5MOUaLXAzkMEKu0x6iCvNqWs8DOxxI/o9l0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=fjTjMoIJyWK64XfMAAzsEsQ3sHzB5v07lpYyV3IZKzuDbYEoVEsPZBxKEnJr4T9NJ PO2q9frTZxn7qYa5P5JE8If1GOPNOAeiGi3JomZd6UI42qN1BZiLkZUyDWSwBs9CJq K4s2+GgfGCSK9qNGvgNIxnt2h4c6BNMY7TzYpU3Q= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 806A96016D; Thu, 27 Jun 2019 17:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561657684; bh=FC/fnWQl5MOUaLXAzkMEKu0x6iCvNqWs8DOxxI/o9l0=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=SKoCozRhabvdQAMNMHG74ZFaSmGTJ/HM8C1N5TWB5wfWzqvXeLyVwVF3EYUj6OjM3 PTcF4ozQu3VlHyK+qlo08t3s+Mn5wqAKKEj5ibNq5yis/374Msk5kECS4jk0nAVtNR cY1SUxvHNlf2Kzpv8kJlYkjDsuHndWGh2Wp5eTNU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 806A96016D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] carl9170: remove dead branch in op_conf_tx callback From: Kalle Valo In-Reply-To: <20190615100009.14654-1-chunkeey@gmail.com> References: <20190615100009.14654-1-chunkeey@gmail.com> To: Christian Lamparter Cc: linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190627174804.669DB60AA8@smtp.codeaurora.org> Date: Thu, 27 Jun 2019 17:48:04 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christian Lamparter wrote: > This patch removes the error branch for (queue > ar->hw->queues). > It is no longer needed anymore as the "queue" value is validated by > cfg80211's parse_txq_params() before the driver code gets called. > > Some background: > In the old days (linux 2.6 and early 3.x), the parse_txq_params() > function did not verify the "queue" value. That's why these drivers > had to do it. > > Signed-off-by: Christian Lamparter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 4ba641262b91 carl9170: remove dead branch in op_conf_tx callback -- https://patchwork.kernel.org/patch/10997023/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches