Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2345845ybd; Thu, 27 Jun 2019 10:50:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAUvZyrvoWE1IXXiYpzxD+QF+sOSfXQwtygBxG+OFQ2djoqBaZVWqwIKgtzsEphy58KulF X-Received: by 2002:a65:408d:: with SMTP id t13mr4826758pgp.373.1561657811381; Thu, 27 Jun 2019 10:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561657811; cv=none; d=google.com; s=arc-20160816; b=ETtsrYx1L/DRMnBZc5Xu6mdgLbU4tIzYuuEHkmBTvrjN1ploupcDBqgoyl129Flzrr AyqyaxJ3iqEjoSDuPFlcrWiIbrq3pM7oKWBP8PA+JfZ2wqi+jz0uIzbo7xBJ6AMU3zFY 3xFjEhjUOrmQl6c8VfmwLYmXbUkx/L+6lT/feUnfMx+ArNF16zeqlUTt0Py1H0IbVNNG d6QDiT7Wl2cgEs4MMtWOQ7VH8Y1fMAi9Ih+Tu+eNb99hkSB3dIgiuTQmrh1J0kc1Z2L9 G6xC0XXfHxkBzkftzb5r14KQK8TGKQNAGKJzTNUFsJgLkNpzF37rYTMuEota5WXhc1mw gKxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=DLZkCjRvfwB+jPcOxC5MC2dX32SXpOOFX5Inv5DwF1c=; b=v9NUorijj0tiTraT8k5essk9mYSvQoWkCtNNtgWmDC1sEwTseQD6ZSQW8KjNQIzCD9 OVb9SmeHKZoUK9K0UovNb+N6i4U2SJ82q9ekaSVPlgzoxUHIc7+8MKROlxPwX0Bb03rW fph6XKLtLRMNVBo8oaQ3Gacbb1nW7UfSz56MFPZCGjKMltPCRcQi5O2+tarljpAyUcs7 ln1yBdwOTpiOSj60LtVF1MOG7jHJpMOfwCqMKZNuU0irzH5AzfRsVl7jH3C905g/d5DC +ZgHfVjCYymROd+ZfA2Z8Z2uOjdkZX6mlOgPdl0N0Pk0mY0mQZGd121hgcOStNxc067+ sXaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=S04I4fOB; dkim=pass header.i=@codeaurora.org header.s=default header.b=IKP+eryR; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si204998pfc.155.2019.06.27.10.49.56; Thu, 27 Jun 2019 10:50:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=S04I4fOB; dkim=pass header.i=@codeaurora.org header.s=default header.b=IKP+eryR; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfF0Rsv (ORCPT + 99 others); Thu, 27 Jun 2019 13:48:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53682 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfF0Rsv (ORCPT ); Thu, 27 Jun 2019 13:48:51 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 72D48607CA; Thu, 27 Jun 2019 17:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561657730; bh=qED9uKP5F5WoOP06iz8bukm7ZaG+W6I585cBXO19cj0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=S04I4fOBg19EUUHrFO3It4BfVcDg0ZJw6LEbgtERdaCHcrmBm3EWOGlxi4/uWUTp2 M8VgIW4Nf2X7as3sZSWNOtBuKRgOovLXuWiJfGFnbvfpBrgdyeSsea/tIkYHl7TUTc 8BNBojD/lmM4fBRRu9tCzBq+cVDt2JlHbWA7P0DE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EB53D602BC; Thu, 27 Jun 2019 17:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561657730; bh=qED9uKP5F5WoOP06iz8bukm7ZaG+W6I585cBXO19cj0=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=IKP+eryRm4WL82EVCLjnTXs4pqPnsJplUYG9BhlFIZArsP5Jj2si78JDU7cpnShtJ H/yD564G0Fw5FqI+QKFO/tO/iMBODhfg3GNABMerQz+sHC0SPSeODZ+65JvlD+kdRE 2zdbhm8VnqSPrivyHPwZr0n3NUPuLGcEvkoHLQRc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EB53D602BC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wireless: wil6210: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190611191024.GA17227@kroah.com> References: <20190611191024.GA17227@kroah.com> To: Greg Kroah-Hartman Cc: Maya Erez , "David S. Miller" , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190627174850.72D48607CA@smtp.codeaurora.org> Date: Thu, 27 Jun 2019 17:48:50 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Maya Erez > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Cc: wil6210@qti.qualcomm.com > Signed-off-by: Greg Kroah-Hartman > Reviewed-by: Maya Erez > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ce564170dfe5 wil6210: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/10988197/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches