Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e293e8e7b38ba504eec40f396d21d3271c780a85.camel@sipsolutions.net>
Subject: Re: [RFC V2 5/8] cfg80211: add 6GHz in code handling array with
 NUM_NL80211_BANDS entries
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 28 Jun 2019 15:03:58 +0200
In-Reply-To: <1561461027-10793-6-git-send-email-arend.vanspriel@broadcom.com>
References: <1561461027-10793-1-git-send-email-arend.vanspriel@broadcom.com>
         <1561461027-10793-6-git-send-email-arend.vanspriel@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-06-25 at 13:10 +0200, Arend van Spriel wrote:
> 
> +++ b/net/wireless/trace.h
> @@ -2446,10 +2446,11 @@
>  		       sizeof(int) * NUM_NL80211_BANDS);
>  	),
>  	TP_printk(WIPHY_PR_FMT ", " NETDEV_PR_FMT ", "
> -		  "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 60GHz=0x%x]",
> +		  "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 6GHz=0x%x, 60GHz=0x%x]",
>  		  WIPHY_PR_ARG, NETDEV_PR_ARG,
>  		  __entry->mcast_rate[NL80211_BAND_2GHZ],
>  		  __entry->mcast_rate[NL80211_BAND_5GHZ],
> +		  __entry->mcast_rate[NL80211_BAND_6GHZ],
>  		  __entry->mcast_rate[NL80211_BAND_60GHZ])
>  );

This doesn't really - you just pointed out that legacy rates aren't
permitted, and so this bitmap doesn't make sense for 6 GHz?

johannes