Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <43145d452ad33bfa39e5bdb5e522cc82140de23b.camel@sipsolutions.net>
Subject: Re: [PATCH v3 1/2] nl80211: Add support for EDMG channels
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexei Lazar <ailizaro@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Date:   Fri, 28 Jun 2019 15:07:33 +0200
In-Reply-To: <40d70ed94b1d79d481511031e8f4ea45@codeaurora.org>
References: <1558364020-11064-1-git-send-email-ailizaro@codeaurora.org>
         <1558364020-11064-2-git-send-email-ailizaro@codeaurora.org>
         <d1c2fd8d99d8f8420ba265f31709da9326ad38f1.camel@sipsolutions.net>
         <40d70ed94b1d79d481511031e8f4ea45@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-06-25 at 13:21 +0300, Alexei Lazar wrote:
> 
> > >   * @NL80211_BAND_ATTR_VHT_CAPA: VHT capabilities, as in the HT 
> > > information IE
> > >   * @NL80211_BAND_ATTR_IFTYPE_DATA: nested array attribute, with each 
> > > entry using
> > >   *	attributes from &enum nl80211_band_iftype_attr
> > > + * @NL80211_BAND_ATTR_EDMG_CHANNELS: bitmap that indicates the 2.16 
> > > GHz
> > > + *	channel(s) that are allowed to be used for EDMG transmissions in 
> > > the
> > > + *	BSS as defined by IEEE 802.11 section 9.4.2.251.
> > > + * @NL80211_BAND_ATTR_EDMG_BW_CONFIG: Channel BW Configuration 
> > > subfield
> > > + *	encodes the allowed channel bandwidth configurations as defined by
> > > + *	IEEE 802.11 section 9.4.2.251, Table 13.
> > >   * @NL80211_BAND_ATTR_MAX: highest band attribute currently defined
> > >   * @__NL80211_BAND_ATTR_AFTER_LAST: internal use
> > 
> > And ... that makes more sense than the global attribute I guess?
> 
> We feel it belongs to the BAND attributes because for example also VHT
> capability is there. There are however 2 other options:
> 1. Move the attribute to the NL80211_FREQUENCY_ATTR
> 2. Move them to the global attributes
> Any preference?

I think I just got confused. Is this used for capability reporting then?
I guess that'd make sense here, yeah.

johannes