Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3458322ybi; Tue, 2 Jul 2019 08:08:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyomAHaDVigSRaLjgddT1kO0EnQuEb5FZxYkgFQbo7GhLTxsbC2hL2yjlQLW6aybt+xAFt X-Received: by 2002:a63:1e0b:: with SMTP id e11mr8862110pge.402.1562080103523; Tue, 02 Jul 2019 08:08:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562080103; cv=none; d=google.com; s=arc-20160816; b=wle+3tjJo2ttrK+/lDGXHiLpjZI4U8kCedI0A56rCEAgkIKouINpHu5Nn4zUNOsi8I fII8biEnXtl42Pmoj6JX94jJTq3QQ9KZxOkxPW3RhqdV1bfmYgBxLsKsxB+5+Q6zv5za ev3gfR9tqcnlZTRGBL6B33NCNuGIw5oRXplqoV2+0y/tu9feiZaldXtKr1NHIJR7MASX 0Z06oovG6nQTdUaN19pA1YP4NdFw/Zs5vJmj4FgCrrTPO4OqDK1yR/wsIvBVV+2RUmxN NC5jhqEczCLocOHiV35UAQ0oROy8jWr+rceUgLLPQsg/hdyUoTlZHgxIjvSaS+vR/VWA zjsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=h5aTC2dUKQjlk6148TQQdZM6PUZC/CtU8nVMM+mqxCk=; b=EB1VcfJeorbGin0JtQ9iHvkXdvZolwBrLanCq2K1p94YeYz23RMxY5Vhfn3e4KdHRY PZbAmHEW++A95dhOjoV/iwO0Axyam5zwb/IeCmWyB9dDoLF9myG2FwUZg04AlZswCBLc yRYMKJHA3VocvZ0/SF2l1HpnZK+MEgdByeUl76dk9a+ndGzGmekOk+uZQleq2dWZBQ+P pQ8w2tpXtCmocufIaqULzAA1ZAzrIOLyF4QRUyTeVITDruEf6i9ChQEAa5xZMFJF50IK RUwhzoR4fAT/3llv1JSqY7/TXMu8sQEfePia7fajLvtYikhA25w5j3sNGrXj5FdaAZVX rcRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j33si12994567pgi.89.2019.07.02.08.08.08; Tue, 02 Jul 2019 08:08:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725922AbfGBPGN (ORCPT + 99 others); Tue, 2 Jul 2019 11:06:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfGBPGN (ORCPT ); Tue, 2 Jul 2019 11:06:13 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 484303082EF1; Tue, 2 Jul 2019 15:06:13 +0000 (UTC) Received: from localhost (unknown [10.43.2.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id E419F1750A; Tue, 2 Jul 2019 15:06:11 +0000 (UTC) From: Stanislaw Gruszka To: linux-wireless@vger.kernel.org Cc: Felix Fietkau , Lorenzo Bianconi , Stanislaw Gruszka Subject: [PATCH 2/3] mt76: usb: remove unneeded {put,get}_unaligned Date: Tue, 2 Jul 2019 17:06:00 +0200 Message-Id: <1562079961-15527-3-git-send-email-sgruszka@redhat.com> In-Reply-To: <1562079961-15527-1-git-send-email-sgruszka@redhat.com> References: <1562079961-15527-1-git-send-email-sgruszka@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 02 Jul 2019 15:06:13 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Compiler give us guaranties on variables alignment, so use an variable as buffer when read/write registers and remove unneeded {put,get}_unaligned. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 5 ++++- drivers/net/wireless/mediatek/mt76/usb.c | 8 ++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h index 56bf93a8988e..094e6e543542 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76.h +++ b/drivers/net/wireless/mediatek/mt76/mt76.h @@ -389,7 +389,10 @@ enum mt76u_out_ep { #define MCU_RESP_URB_SIZE 1024 struct mt76_usb { struct mutex usb_ctrl_mtx; - u8 data[32]; + union { + u8 data[32]; + __le32 reg_val; + }; struct tasklet_struct rx_tasklet; struct delayed_work stat_work; diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index db90ec6b8775..a61bb8171557 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -95,9 +95,9 @@ static u32 __mt76u_rr(struct mt76_dev *dev, u32 addr) ret = __mt76u_vendor_request(dev, req, USB_DIR_IN | USB_TYPE_VENDOR, - 0, offset, usb->data, sizeof(__le32)); + 0, offset, &usb->reg_val, sizeof(__le32)); if (ret == sizeof(__le32)) - data = get_unaligned_le32(usb->data); + data = le32_to_cpu(usb->reg_val); trace_usb_reg_rr(dev, addr, data); return data; @@ -131,10 +131,10 @@ static void __mt76u_wr(struct mt76_dev *dev, u32 addr, u32 val) } offset = addr & ~MT_VEND_TYPE_MASK; - put_unaligned_le32(val, usb->data); + usb->reg_val = cpu_to_le32(val); __mt76u_vendor_request(dev, req, USB_DIR_OUT | USB_TYPE_VENDOR, 0, - offset, usb->data, sizeof(__le32)); + offset, &usb->reg_val, sizeof(__le32)); trace_usb_reg_wr(dev, addr, val); } -- 1.9.3