Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1862434ybi; Thu, 4 Jul 2019 00:54:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAMgsyhHdtYP24CY/MN5Io0POhUEqvSKy7LkCWPQdd87moFMkhwgBA1Kg7ttp4SjiBCH3a X-Received: by 2002:a17:90a:fa07:: with SMTP id cm7mr17597692pjb.138.1562226846554; Thu, 04 Jul 2019 00:54:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562226846; cv=none; d=google.com; s=arc-20160816; b=C80B3YaDLHH2it4l0XSo7RP6rWUkW/O0PHmSe6+FnfeaHHJTmz66QQjh5T6LE69RC8 XHU0Zw+bbJwrxLZyDczyO6tcsbFBifBLQAGkYsrsau3aotgr1v/EFPv1S2sVGt0A0Jwf Ay+4rh9YcbLi3/Rl2voHHcKs29pWNF8rZfZkUJETNbJyiFu7tszKBPluQWlupprbkx3c 1uSJ1NPZgvCTwUKf6qmUJIodwf0sPbMkbKxWwB/MHX1qs13rOO+UQhCsy6ztyK8OSoD8 B/MXViDc75Mt0OhetRz9rmUmZjuJnc2wqcUb3cZECVkes5pZhA3GiVWyrT3ulZh5l6CF Lpkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Buzzf1MtAoj7VkPwTgh3/MzUhN1/LqKLEWbwD8f10Jw=; b=Z0kU+lJyloYjkUR4puwPsFx+jxHdQLdtX8hL7so3aCM9fSc1GZCtTKHp4JZRGijEB7 T72VMJwqu+symNW6e3XXa6QKRHbDfKVusvDlZGOQZomopdSJ9k+HIj1u7M33R/BE3EQS W7U0MlVaQwlHhHCi2v7BLJYnSm198++1JeGznDllcp8+mI1dq7vDO8AfEQaMq3vyER1i lpNIHvEmxpm7lc0+ATjlLTg/akSespARysw+vUKmt7zCLhIr2BjA1txPN4kCJPSTmY9u jYUktVkeubjObNMA7XL9XRKwhZHxRX0OnBNWnP0qPrme1K1NUAV059zmkAQIY4DndMFJ fPbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q75si4744126pgq.538.2019.07.04.00.53.38; Thu, 04 Jul 2019 00:54:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfGDHu4 (ORCPT + 99 others); Thu, 4 Jul 2019 03:50:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37016 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfGDHu4 (ORCPT ); Thu, 4 Jul 2019 03:50:56 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1650430832C3; Thu, 4 Jul 2019 07:50:56 +0000 (UTC) Received: from localhost (ovpn-204-226.brq.redhat.com [10.40.204.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21D8D86BB0; Thu, 4 Jul 2019 07:50:52 +0000 (UTC) Date: Thu, 4 Jul 2019 09:50:52 +0200 From: Stanislaw Gruszka To: Greg Kroah-Hartman Cc: Helmut Schaa , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] rt2x00: no need to check return value of debugfs_create functions Message-ID: <20190704075051.GB25102@redhat.com> References: <20190703065631.GA28822@kroah.com> <20190703113956.GA26652@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703113956.GA26652@kroah.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 04 Jul 2019 07:50:56 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jul 03, 2019 at 01:39:56PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Because we don't need to save the individual debugfs files and > directories, remove the local storage of them and just remove the entire > debugfs directory in a single call, making things a lot simpler. > > Cc: Stanislaw Gruszka > Cc: Helmut Schaa > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Acked-by: Stanislaw Gruszka