Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7717819ybi; Tue, 9 Jul 2019 03:13:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLsBz2bBnkESZMMFT90NyJVQ1UIuACJwGkmjWkL1de8My85P+pzDTJ/0O5PRb6t2cexJBJ X-Received: by 2002:a17:902:b20c:: with SMTP id t12mr31144558plr.285.1562667230919; Tue, 09 Jul 2019 03:13:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562667230; cv=none; d=google.com; s=arc-20160816; b=01xHkVeX8s3P+WBGDg8J/M2qgHpQTTVaVQvrwFJ10racOldqs/ynKMRCwjixu3nd4V 7F2lJlbrE0qbtTB2gM5NgiqfPlh0sEJLjN9y2Q5s7YRmtFjP+ZY6A9kwOLZLoaMR1Rii puknRSikNNTE9Ei3hBQ2tXcgeWPdNuocwoWnWP5U7/nGrD7eGPzA8j6RYNLvnHvLmCJA rVHEEIOtyEF7LWr7zuclm5P/dCQZsdLI2BKz6Bv6XpecAuLNTss+zFVc14YCaSEK6YaX EqYzqHT8+OZE//putjltoo8GwnTlrjw5zZyMoXQI8JALqZ942V4uQbJBQBDjXjdygZit MTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=71Uszt08JUuV4EEpb+sircaWzi0TBp+dH1RcpLP3ceo=; b=xjd1TVfYfVxlwC7R2Kyrc/hRrYJ7RnHtIlxeb6yr6S3beQO9xG9qNG5TCyqLcNPpax RrlEIdV4UyEnFps3HgzChmaCUhs4nDxMr6rpp1mJqBv7otdlkJIp2jpYFVJn1qYCD3Zd 58GTPBfOmUwvQt35prLmRRBYd8hL96qsQp/ZBpfQn9ZHjrd54lQ5JkhtSDRUe3a4ZkhP rEKvaUDg2JHE/JdZFFXKgbP1p5lFila10o+CulgTX4QHdk3HGpWgyr72NjBk1u8wOjX7 L0nIc4hqN7BYvcH2valBdQmGJDhmrkEAP8GyStPu1srHvYWPoZQr2mvHbYzbPyBs7lj+ pIHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4si2130181pjn.93.2019.07.09.03.13.36; Tue, 09 Jul 2019 03:13:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbfGIKMe (ORCPT + 99 others); Tue, 9 Jul 2019 06:12:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbfGIKMe (ORCPT ); Tue, 9 Jul 2019 06:12:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC76890C7A; Tue, 9 Jul 2019 10:12:28 +0000 (UTC) Received: from localhost (unknown [10.43.2.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52B471001B34; Tue, 9 Jul 2019 10:12:26 +0000 (UTC) Date: Tue, 9 Jul 2019 12:12:24 +0200 From: Stanislaw Gruszka To: linux-wireless@vger.kernel.org Cc: Felix Fietkau , Lorenzo Bianconi Subject: Re: [PATCH 3/3] mt76: usb: use full intermediate buffer in mt76u_copy Message-ID: <20190709101223.GB3099@redhat.com> References: <1562079961-15527-1-git-send-email-sgruszka@redhat.com> <1562079961-15527-4-git-send-email-sgruszka@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562079961-15527-4-git-send-email-sgruszka@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 Jul 2019 10:12:34 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jul 02, 2019 at 05:06:01PM +0200, Stanislaw Gruszka wrote: > Instead of use several 4 bytes usb requests, use full 32 bytes buffer > to copy data to device. With the change we use less requests and copy > exact data size to the device regardless size is multiple of 4 or not. And this does not work correctly on some usb hosts, request which are not multiple of 4 do not ended being written to hardware, what results in original problem of having last part of beacon corrupted. I would prefer to drop this set - and I would post 2 patches (first patch fixed and third dropped). But since this is now in Felix's wireless tree I guess I need to post fixes on top of this set? Stanislaw