Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8047553ybi; Tue, 9 Jul 2019 08:18:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzATM5BS34PVxq9bPKPhJCWffySxszFpblzMusSp8GEYuWmVfHYM9sgZxwq12exfpZ0ujpv X-Received: by 2002:a63:2bd2:: with SMTP id r201mr30791781pgr.193.1562685510218; Tue, 09 Jul 2019 08:18:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562685510; cv=none; d=google.com; s=arc-20160816; b=hSb7JqRj5ts8QTkQZpLi5J/2f8jIgMrInKIGNLmCk82qKuM2hbW10ftJYxp8PHU3I/ V41md3bz0oy48GVScTw4UvHPQW8IN3wBbtrEzhn47gjaVfKYJ6VyWZesvmP0j5rjmAlo sBOazO/8mKqBjUmbBIlYeJaa24izJ2dZGAqNtujySA+eCf75oMh0JDtjr7nplFhw4khw Xm5sx4Sia08k3FNfkfGVEzNVl6eA7E/wuRVEaWjbdtTOQQpZZ3eYb23wsosGKBGpnWTg QfSuc3GqsO5kFOvc54PbwIUJgkN+chtNAh64oaGkaKYOAbtAnk8QMAG6Uiyhmghfb18s 3dUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YzDhX0L7ME2wO/Hah4QjVnBYj3QCtEHefTKvFI9bUaE=; b=ua9JdAfcH22IpD8XptgpV2RHKrkGWupGIF1RUf3VsNGFAdtd9A9RZ8nvo0kJNkGYUL YIwNMYsZQUDXt/JyRX5ykzdzv5k1+VnFLyUyHZOmtkMPeo0Y7Tm4TRr8guaLTZovTwwb Uh+v/SKkjbEAeuUDwPlTEzWK7zC8Yz53X6c1SY9jQ7Dy/uqBHUWPiWX2T68btnc3YhI7 Y3Vxl2usy7Eas7XksiUUSJQPis43eNr+rc9BAnpsTGIIt84fRNgR8dfTrrRuEpybLqvq kzZtF1F7/nOWwILTAuFbQLG3q3vWsBkGtdl/8tnxGqGPFM4dR/7/h2OWGUFB9CWX+K4N obRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v197si22678568pgb.29.2019.07.09.08.18.07; Tue, 09 Jul 2019 08:18:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbfGIPPD (ORCPT + 99 others); Tue, 9 Jul 2019 11:15:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55942 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726055AbfGIPPC (ORCPT ); Tue, 9 Jul 2019 11:15:02 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE60BC1EB215; Tue, 9 Jul 2019 15:15:02 +0000 (UTC) Received: from localhost (ovpn-204-53.brq.redhat.com [10.40.204.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08EB64EE0B; Tue, 9 Jul 2019 15:14:59 +0000 (UTC) From: Stanislaw Gruszka To: linux-wireless@vger.kernel.org Cc: Felix Fietkau , Lorenzo Bianconi Subject: [PATCH v2 1/2] mt76: usb: fix endian in mt76u_copy Date: Tue, 9 Jul 2019 17:14:54 +0200 Message-Id: <20190709151455.24003-2-sgruszka@redhat.com> In-Reply-To: <20190709151455.24003-1-sgruszka@redhat.com> References: <20190709151455.24003-1-sgruszka@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 09 Jul 2019 15:15:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In contrast to mt76_wr() which we use to program registers, on mt76_wr_copy() we should not change endian of the data. Fixes: b40b15e1521f ("mt76: add usb support to mt76 layer") Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index 5be584ca7497..828939e78a3b 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -165,11 +165,11 @@ static void mt76u_copy(struct mt76_dev *dev, u32 offset, mutex_lock(&usb->usb_ctrl_mtx); for (i = 0; i < DIV_ROUND_UP(len, 4); i++) { - put_unaligned_le32(val[i], usb->data); + put_unaligned(val[i], (u32 *) usb->data); ret = __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE, USB_DIR_OUT | USB_TYPE_VENDOR, 0, offset + i * 4, usb->data, - sizeof(__le32)); + sizeof(u32)); if (ret < 0) break; } -- 2.20.1