Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10243124ybi; Thu, 11 Jul 2019 02:07:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzenxVp5Au33FLap/9xf2nMV3FDvrJwiSrvSL+Vm+48E9B16mfHpJkj5lUevfy8J9YLPrDf X-Received: by 2002:a63:f4e:: with SMTP id 14mr3302469pgp.58.1562836061902; Thu, 11 Jul 2019 02:07:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562836061; cv=none; d=google.com; s=arc-20160816; b=CH1WScl+YfDqjTBxE2EUd/qpruufA2rdEkDFStNFLaOyL2ZqvOGm7UY3nUrTF8+FOV WCCwN3fXxl4e/munu8SLfAYW0A3o8pH0MxaBlqoD4GZhp7By3vRet6CrAK6qhcI+ogOp Gok5SgtzlilQaLg1eoDvc6nM2tqKMptbiXTGqXz4U7zYo2Le4x6AuvlvwgfKhWyrclP+ q3Y62v5lX0eUR6xn9PP/V8lDpsQmeNibXMp2tUK+/h91NFC8my9t7LilIa0zMW2W3rRO aW4Az4AksoipJrOrEIfYFurHjS2SlPGgyKjl8+zW0yDvvL6lxiB60UVCYmFXZ0CkkMQR 8x9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=SD6VKqcry8DTVIjYE4qxpwynUeO8HhPXg41W90TZmGw=; b=DaEqNOnQOATrQkNHJ1RYQvC4q4ViUvKF/0TPRq5l/l5SIfDKXkYUPh8sn88uELFwYa AJu8MwRzJQc3NqGwb2MKiRzIrDeBe8mkUTh/0MkfDAgBwICd+fsCwcRNhU+TAasKaOO4 orPpFG+32/dHgOc/zR3rbO938K0cQ7k5Xj6qkQPUXlq4dHBJzIf/tZSCZoKgZ8HE5LwS Ldi66u7ZbSK5hD9gNNCzdTic+eBkkauKyIMl+cM1ajmMnnVlG0Z+u8ox09zLz4N5wdhq js0vgbTuISPF8zG6FPXKdf5S244ViiBRY98j6K95hbMhCXwsNe3iExu5FRIJNAtEeeBW 5qFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=DuWF8zM4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 28si4822149pgy.252.2019.07.11.02.07.27; Thu, 11 Jul 2019 02:07:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=DuWF8zM4; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728167AbfGKJFW (ORCPT + 99 others); Thu, 11 Jul 2019 05:05:22 -0400 Received: from rnd-relay.smtp.broadcom.com ([192.19.229.170]:59742 "EHLO rnd-relay.smtp.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfGKJFW (ORCPT ); Thu, 11 Jul 2019 05:05:22 -0400 Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 25D6130C002; Thu, 11 Jul 2019 02:05:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 25D6130C002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1562835921; bh=g/LMgTPx7L1+ZSVVf/Oczyafq1NFh+aHznOCzuuukKI=; h=From:To:Cc:Subject:Date:From; b=DuWF8zM4IIHXvDvsbHhl6BybBzpHA+B7YLV1NLiHUVon4OblNrajkhu4waQlhLKQe +mD2saXtpvCejWLq+lqYPevJL2HevUkSDS4yt5y0exJ6nmu1ZeVUmg8MWD4rw5gBVz eqpsk+EOBNsIkUhHgJ/qThf0syOHIAFyqe2jjR80= Received: from bld-bun-01.bun.broadcom.com (bld-bun-01.bun.broadcom.com [10.176.128.83]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 1FD5760D22; Thu, 11 Jul 2019 02:05:21 -0700 (PDT) Received: by bld-bun-01.bun.broadcom.com (Postfix, from userid 25152) id BAAC7B03087; Thu, 11 Jul 2019 11:05:19 +0200 (CEST) From: Arend van Spriel To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Arend van Spriel Subject: [PATCH 0/7] brcmfmac: rework probe/attach sequence Date: Thu, 11 Jul 2019 11:05:05 +0200 Message-Id: <1562835912-1404-1-git-send-email-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The brcmfmac driver spews some error message upon unloading and Stefan Wahren was wondering whether it could be cleaned up. Related to this was a recent fix for NULL pointer deref. That fix introduced a construct that added to the itch to rework the probe sequence. So this series reverts commit 5cdb0ef6144f ("brcmfmac: fix NULL pointer derefence during USB disconnect"). The changes in this series are: * reorder brcmf_detach() code. * avoid firmware interaction when bus is down. * remove strlcpy() before issueing firmware version iovar. This series applies to the master branch of the wireless-drivers-next repository. Arend van Spriel (7): Revert "brcmfmac: fix NULL pointer derefence during USB disconnect" brcmfmac: change the order of things in brcmf_detach() brcmfmac: avoid firmware command in brcmf_netdev_open() when bus is down brcmfmac: clear events in brcmf_fweh_detach() will always fail brcmfmac: avoid firmware commands when bus is down brcmfmac: simply remove flowring if bus is down brcmfmac: remove unnecessary strlcpy() upon obtaining "ver" iovar .../wireless/broadcom/brcm80211/brcmfmac/bcdc.c | 11 ++------ .../wireless/broadcom/brcm80211/brcmfmac/bcdc.h | 6 ++--- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 23 +++++++++-------- .../wireless/broadcom/brcm80211/brcmfmac/common.c | 1 - .../wireless/broadcom/brcm80211/brcmfmac/core.c | 30 +++++++++++----------- .../wireless/broadcom/brcm80211/brcmfmac/fweh.c | 9 ------- .../broadcom/brcm80211/brcmfmac/fwsignal.c | 16 +++--------- .../broadcom/brcm80211/brcmfmac/fwsignal.h | 3 +-- .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 7 +++++ .../wireless/broadcom/brcm80211/brcmfmac/proto.c | 10 ++------ .../wireless/broadcom/brcm80211/brcmfmac/proto.h | 3 +-- 11 files changed, 47 insertions(+), 72 deletions(-) -- 1.9.1