Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10508863ybi; Thu, 11 Jul 2019 06:28:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZMq/0tVLbSvRdiJZBZOPnMRXPPuuTwGJ8NvZL2kzlPeJZO/BavljQZZjzK/KUeYTJmCDR X-Received: by 2002:a17:902:a60d:: with SMTP id u13mr4789952plq.144.1562851707325; Thu, 11 Jul 2019 06:28:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1562851707; cv=pass; d=google.com; s=arc-20160816; b=yJR/fx1PQoS+E98G5bVZ/FnBPE8aZehJPFE0gJzL+JtvBWoAi/NH4YfE9CmqNhJ1oe 7bov5PIuFykIrkL3cs5FZnyR+4n35gn1Olv4Pm3i6IfFCuxRgmxMeziz/8mFD7Qpjh3V Ravj4gXCkQDEKhQvneG/1RzN1YVbRfUOR3trYnbiOu92OvdP2ni9wRpjoyQNVyMnfYx/ I/+v91z+MBj/zSzihDMVcOoHTpCxYn6cgrLZKMSZg1LbwbpmVvDGMH+3SYX9zZxh37rW TwKwkdycDfQEktYW5MfPCsFL37yb9osNG5oIG4ABpLwow6kLaFU78GzAz9z/q5Pyr4cn P7ng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=F95ylwJbTc+FmO+HI4xSEopLm/KBYGzwjZW5lB9o4+U=; b=ZCejeWGZv27p74M3YSxpq8YIaSWrtv12KBcsmDF4f9orYGg9PGqh6JVoR68w3rsoEQ xLv5dE9X5zWUbCFgKJusSDvUZuqPoViBpa0nQEQNvCBNTS+TqJYQfc8pZUwftZ+8AdIt cysGaxYeaA2irsAOWH61w3pPpFK900iz2MjYPV5y3X6wKhA0p0LDLTPb5zspbKgXIzOa J6LQDpOAJ6VhWxNtQxgginhi6nvKecVAklEf6u0b1BS5eonTfZjN2WE1oxUgrP5JM6UY ftbiVIDTGSXTopFNJmgy3wEXKCCtdHIDjYVXK8Q4xzQx0/dBxFQdFRUseqexXeC7WIM8 gnfg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quantenna.com header.s=selector2 header.b=V44bUxq1; arc=pass (i=1 spf=pass spfdomain=quantenna.com dkim=pass dkdomain=quantenna.com dmarc=pass fromdomain=quantenna.com); spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18si5279995pfd.144.2019.07.11.06.28.12; Thu, 11 Jul 2019 06:28:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@quantenna.com header.s=selector2 header.b=V44bUxq1; arc=pass (i=1 spf=pass spfdomain=quantenna.com dkim=pass dkdomain=quantenna.com dmarc=pass fromdomain=quantenna.com); spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbfGKM45 (ORCPT + 99 others); Thu, 11 Jul 2019 08:56:57 -0400 Received: from mx0b-00183b01.pphosted.com ([67.231.157.42]:22104 "EHLO mx0a-00183b01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726016AbfGKM44 (ORCPT ); Thu, 11 Jul 2019 08:56:56 -0400 Received: from pps.filterd (m0048104.ppops.net [127.0.0.1]) by mx0b-00183b01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6BCqZYt008240; Thu, 11 Jul 2019 06:55:05 -0600 Received: from nam03-by2-obe.outbound.protection.outlook.com (mail-by2nam03lp2056.outbound.protection.outlook.com [104.47.42.56]) by mx0b-00183b01.pphosted.com with ESMTP id 2tnxk30vnf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Jul 2019 06:55:05 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GImgMg5qkeZx6+pUQm3rLjEt1a3ExO58Rce0YFmNdqV/U3X4l+GsWki8pVy9H27WAHP8xB2id3guYZQ3wa0DpPPhP9CWBlQLmg+TyNuPN0zWT1QRQ18Dob45cI8sMoBEYO2tkf++2B6lgRlmihGCC34pXSgviq7MIc9re6zQUlmr1MlY5i3b1A3eN1DsJpafh4MZU1zCbjauM2Fabgq6sJXYmuxWNTSOcVAfQck+xhxQPW2cwxAQqYQc68THK+cbFkNFNU57fMpFBcO5BxwbIPsZFmX/GsCrrHDdWNkN8GRE4+lOEuCS/RjMO38G9nx9oi8Nau63NH3rW/Fmls3V+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F95ylwJbTc+FmO+HI4xSEopLm/KBYGzwjZW5lB9o4+U=; b=jH0+67RXVTX/DBlzizokBPDRY5nIdlfL6vGPViFYTvnlClgfCTLK0mI50InxTv6F9M0GgXZjosqDpmbqoYi/H9CQGz7xCXcRSaSbWasyh9ePE1CK9JgqzYc0KHBTsLt47kQmnFgNDBny2xLtu1fQFi9OdF3ZfuYVESEX4LmQiccHfcIOVsugZ5V7pUa+3UouC0v93fWxkyKWz03U6bAun+SRTvCmL7rHb0o1F5pXlZDd1Jn/tAPSfNPahhH8JYXPvEeyTAcYYHw7/tLYDLMQMYHqoPfe4QEQ3byMFTM7Pxa/kVj5Tsp4ShPCMETxCatMbzuIpPFk+SF2RcwIONJgew== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=quantenna.com;dmarc=pass action=none header.from=quantenna.com;dkim=pass header.d=quantenna.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quantenna.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F95ylwJbTc+FmO+HI4xSEopLm/KBYGzwjZW5lB9o4+U=; b=V44bUxq1au7cT2s2yPiIvIzpaD4Cjpvs7mU/Xl20+PpuIA4coeOnk40g/j5QUMp9vMyUIa7Gjhg+JmzE5/D0+7jXiUkncW9G1l6DPyxX8Q+UvWHwnoErvMy5vj+H9MWd7oq1tC2B6W+z3rKK6PS/pT4+E0kCoRsdwDGn5C9El8g= Received: from SN6PR05MB4174.namprd05.prod.outlook.com (52.135.67.141) by SN6PR05MB5790.namprd05.prod.outlook.com (20.178.7.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.7; Thu, 11 Jul 2019 12:55:03 +0000 Received: from SN6PR05MB4174.namprd05.prod.outlook.com ([fe80::68da:521d:d75c:5dad]) by SN6PR05MB4174.namprd05.prod.outlook.com ([fe80::68da:521d:d75c:5dad%7]) with mapi id 15.20.2073.008; Thu, 11 Jul 2019 12:55:03 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com (52.135.117.74) by SN6PR05MB5647.namprd05.prod.outlook.com (52.135.111.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Thu, 11 Jul 2019 12:54:49 +0000 Received: from SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::13f:5819:79e7:ea8f]) by SN6PR05MB4928.namprd05.prod.outlook.com ([fe80::13f:5819:79e7:ea8f%5]) with mapi id 15.20.2073.008; Thu, 11 Jul 2019 12:54:49 +0000 From: Sergey Matyukevich To: Tamizh chelvam CC: "johannes@sipsolutions.net" , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Thread-Topic: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Thread-Index: AQHVJaGs5+plNin5xE2WE4mORkW386bFhFqA Date: Thu, 11 Jul 2019 12:54:48 +0000 Message-ID: <20190711125442.unlaqjl5nnqgsbod@bars> References: <1560835632-17405-1-git-send-email-tamizhr@codeaurora.org> <1560835632-17405-6-git-send-email-tamizhr@codeaurora.org> In-Reply-To: <1560835632-17405-6-git-send-email-tamizhr@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR08CA0056.namprd08.prod.outlook.com (2603:10b6:a03:117::33) To SN6PR05MB4928.namprd05.prod.outlook.com (2603:10b6:805:9d::10) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [195.182.157.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38eeecce-f6b0-4bb6-86d3-08d705fef50f x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:SN6PR05MB5647; x-ms-traffictypediagnostic: SN6PR05MB5647:|SN6PR05MB5790: x-microsoft-antispam-prvs: x-moderation-data: 7/11/2019 12:55:02 PM x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0095BCF226 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(346002)(366004)(39830400003)(396003)(376002)(136003)(189003)(199004)(436003)(81166006)(81156014)(26005)(102836004)(7736002)(2906002)(5660300002)(25786009)(8676002)(54906003)(1076003)(305945005)(186003)(6916009)(9686003)(316002)(66446008)(64756008)(6512007)(66556008)(256004)(66946007)(66476007)(6246003)(53936002)(8936002)(71200400001)(71190400001)(4326008)(6486002)(6436002)(33716001)(229853002)(99286004)(6116002)(3846002)(386003)(6506007)(86362001)(52116002)(76176011)(478600001)(486006)(476003)(11346002)(66066001)(14454004)(68736007)(446003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR05MB5790;H:SN6PR05MB4174.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: quantenna.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0wNR0BIQWsmekyo/uvWPnQR4REYZuIVyOf0uWSiIPb4NBCsUjWuuPmGheC/xwUFqCm5s/eUZ+9zho9IyUFvwwJtYYQmpqBDiIXHggSelfHTy5HzwjJZSSI2b8gfdUFqIu22pXa7ltemixdQHbNY8LgOo6WKyrET+7dxAokauCsegpDXM109vM3W+Y+h2J8gkO/GS5NhScgD/MVuo2/neAwFoCUCjS7Oy/1YMLXOZ9sUvXsip0rqTzclc1KJ601MAWmJTFNDDlHY9gQzUgb1iX15OFOPnIpZWXtD7bBZPBr/lHrQ6sAx5RU2LxSRSuF8yAM9UqeFq5O9IRwhhQ4X1Xtuzc6xo06D3o8CiVd6Ytioa3R0G/eH0BczQ5RtHgndqPVzs8ww12BcvXYeQFm/+vGtQw9auJ/McSVxhS0Ml0ak= Content-Type: text/plain; charset="us-ascii" Content-ID: <1C243749BB147E41A5268EBD4E997466@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38eeecce-f6b0-4bb6-86d3-08d705fef50f X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPO_Arbitration_9454465f-4b3d-47c4-906a-0e3cbbb71a30@quantenna.onmicrosoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 12:55:03.6490 (UTC) X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5790 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-11_02:,, signatures=0 X-Proofpoint-Spam-Reason: safe Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Introduce NL80211_TID_ATTR_CONFIG_TX_RATES in nl80211_tid_attr_config > to accept data TID specific TX bitrate configuration > through NL80211_CMD_SET_TID_CONFIG command. TID for which the > this configuration is to be applied is passed in > NL80211_TID_ATTR_CONFIG_TID attribute. TX bitrate mask values passed > in NL80211_ATTR_TX_RATES attribute and NL80211_TID_ATTR_CONFIG_TX_RATES > attribute will have types of the TX rate should be applied. > When the user-space wants this configuration peer specific > rather than being applied for all the connected stations, > MAC address of the peer can be passed in NL80211_ATTR_MAC attribute. >=20 > Driver supporting this feature should advertise > NL80211_EXT_FEATURE_PER_TID_TX_BITRATE_MASK and supporting per-STA data T= ID > TX bitrate configuration should advertise > NL80211_EXT_FEATURE_PER_STA_TX_BITRATE_MASK. >=20 > Signed-off-by: Tamizh chelvam ... > if (info->attrs[NL80211_ATTR_TX_RATES]) { > - err =3D nl80211_parse_tx_bitrate_mask(info, ¶ms.beaco= n_rate); > + err =3D nl80211_parse_tx_bitrate_mask(info, info->attrs, > + NL80211_ATTR_TX_RATES= , > + ¶ms.beacon_rate); > if (err) > return err; >=20 Could you please clarify this change of nl80211_parse_tx_bitrate_mask argum= ents. Unless I missing something, the appropriate change for nl80211_parse_tx_bit= rate_mask is not included into this patch set. Regards, Sergey