Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Tamizh chelvam <tamizhr@codeaurora.org>
CC:     "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID
 specific tx rate
Thread-Topic: [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID
 specific tx rate
Thread-Index: AQHVJaGs5+plNin5xE2WE4mORkW386bFhFqA
Date:   Thu, 11 Jul 2019 12:54:48 +0000
Message-ID: <20190711125442.unlaqjl5nnqgsbod@bars>
References: <1560835632-17405-1-git-send-email-tamizhr@codeaurora.org>
 <1560835632-17405-6-git-send-email-tamizhr@codeaurora.org>
In-Reply-To: <1560835632-17405-6-git-send-email-tamizhr@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [195.182.157.78]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 38eeecce-f6b0-4bb6-86d3-08d705fef50f
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:SN6PR05MB5647;
x-ms-traffictypediagnostic: SN6PR05MB5647:|SN6PR05MB5790:
x-microsoft-antispam-prvs: <SN6PR05MB56478C25D2E8B9993B9A1694A3F30@SN6PR05MB5647.namprd05.prod.outlook.com>
x-moderation-data: 7/11/2019 12:55:02 PM
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0095BCF226
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(346002)(366004)(39830400003)(396003)(376002)(136003)(189003)(199004)(436003)(81166006)(81156014)(26005)(102836004)(7736002)(2906002)(5660300002)(25786009)(8676002)(54906003)(1076003)(305945005)(186003)(6916009)(9686003)(316002)(66446008)(64756008)(6512007)(66556008)(256004)(66946007)(66476007)(6246003)(53936002)(8936002)(71200400001)(71190400001)(4326008)(6486002)(6436002)(33716001)(229853002)(99286004)(6116002)(3846002)(386003)(6506007)(86362001)(52116002)(76176011)(478600001)(486006)(476003)(11346002)(66066001)(14454004)(68736007)(446003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR05MB5790;H:SN6PR05MB4174.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 0wNR0BIQWsmekyo/uvWPnQR4REYZuIVyOf0uWSiIPb4NBCsUjWuuPmGheC/xwUFqCm5s/eUZ+9zho9IyUFvwwJtYYQmpqBDiIXHggSelfHTy5HzwjJZSSI2b8gfdUFqIu22pXa7ltemixdQHbNY8LgOo6WKyrET+7dxAokauCsegpDXM109vM3W+Y+h2J8gkO/GS5NhScgD/MVuo2/neAwFoCUCjS7Oy/1YMLXOZ9sUvXsip0rqTzclc1KJ601MAWmJTFNDDlHY9gQzUgb1iX15OFOPnIpZWXtD7bBZPBr/lHrQ6sAx5RU2LxSRSuF8yAM9UqeFq5O9IRwhhQ4X1Xtuzc6xo06D3o8CiVd6Ytioa3R0G/eH0BczQ5RtHgndqPVzs8ww12BcvXYeQFm/+vGtQw9auJ/McSVxhS0Ml0ak=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1C243749BB147E41A5268EBD4E997466@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quantenna.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38eeecce-f6b0-4bb6-86d3-08d705fef50f
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SPO_Arbitration_9454465f-4b3d-47c4-906a-0e3cbbb71a30@quantenna.onmicrosoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 12:55:03.6490
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5790
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-11_02:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> Introduce NL80211_TID_ATTR_CONFIG_TX_RATES in nl80211_tid_attr_config
> to accept data TID specific TX bitrate configuration
> through NL80211_CMD_SET_TID_CONFIG command. TID for which the
> this configuration is to be applied is passed in
> NL80211_TID_ATTR_CONFIG_TID attribute. TX bitrate mask values passed
> in NL80211_ATTR_TX_RATES attribute and NL80211_TID_ATTR_CONFIG_TX_RATES
> attribute will have types of the TX rate should be applied.
> When the user-space wants this configuration peer specific
> rather than being applied for all the connected stations,
> MAC address of the peer can be passed in NL80211_ATTR_MAC attribute.
>=20
> Driver supporting this feature should advertise
> NL80211_EXT_FEATURE_PER_TID_TX_BITRATE_MASK and supporting per-STA data T=
ID
> TX bitrate configuration should advertise
> NL80211_EXT_FEATURE_PER_STA_TX_BITRATE_MASK.
>=20
> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>

...

>         if (info->attrs[NL80211_ATTR_TX_RATES]) {
> -               err =3D nl80211_parse_tx_bitrate_mask(info, &params.beaco=
n_rate);
> +               err =3D nl80211_parse_tx_bitrate_mask(info, info->attrs,
> +                                                   NL80211_ATTR_TX_RATES=
,
> +                                                   &params.beacon_rate);
>                 if (err)
>                         return err;
>=20

Could you please clarify this change of nl80211_parse_tx_bitrate_mask argum=
ents.
Unless I missing something, the appropriate change for nl80211_parse_tx_bit=
rate_mask
is not included into this patch set.

Regards,
Sergey