Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Tamizh chelvam <tamizhr@codeaurora.org>
CC:     "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv6 1/9] nl80211: New netlink command for TID specific
 configuration
Thread-Topic: [PATCHv6 1/9] nl80211: New netlink command for TID specific
 configuration
Thread-Index: AQHVJaGvTjP0r5cPcEi6bnoTD8w66KbFiZwA
Date:   Thu, 11 Jul 2019 13:13:37 +0000
Message-ID: <20190711131331.gyjvsbxipgfk5cmn@bars>
References: <1560835632-17405-1-git-send-email-tamizhr@codeaurora.org>
 <1560835632-17405-2-git-send-email-tamizhr@codeaurora.org>
In-Reply-To: <1560835632-17405-2-git-send-email-tamizhr@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [195.182.157.78]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ba8af0bc-d2f3-4cb4-5724-08d70601959a
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:SN6PR05MB4366;
x-ms-traffictypediagnostic: SN6PR05MB4366:|BL0PR05MB4609:
x-microsoft-antispam-prvs: <SN6PR05MB43666CA0126B425E56632218A3F30@SN6PR05MB4366.namprd05.prod.outlook.com>
x-moderation-data: 7/11/2019 1:13:51 PM
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0095BCF226
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(376002)(39850400004)(366004)(346002)(396003)(136003)(189003)(199004)(316002)(386003)(54906003)(26005)(6506007)(8676002)(102836004)(8936002)(25786009)(186003)(7736002)(81156014)(81166006)(9686003)(229853002)(99286004)(2906002)(3846002)(6116002)(6512007)(436003)(305945005)(66476007)(53936002)(86362001)(52116002)(14444005)(6436002)(6486002)(66066001)(1076003)(6246003)(4326008)(71200400001)(446003)(66946007)(11346002)(66446008)(68736007)(71190400001)(486006)(33716001)(478600001)(5660300002)(66556008)(14454004)(6916009)(476003)(256004)(76176011)(64756008);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR05MB4609;H:BL0PR05MB4881.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: C4hoAyUviwlVgcZiEnsKFZTOSorFvq4+l0f4byaurQpqzOviGKUwooPutj4dXZiHUI9gL2QmOC0ckOtQLomA+jlwdoMOWXlKjbDR5aktB3g05hMtnt9FXknbg2IEuJzy1tfn3oVr1HtMDQi6IeoMxxkeBlH+JXc3zwifc/524nrPg6o5txD4YqrRpQaX2eDSsZYr45Zymj42+EL3AlhieBe1rRfAjr+dO0qQZ6UMoR803l356TN8iq0XUFc4NgkY95dYNdDphZ6B2XBuEVc72UOukakCIKy39Lz4601/ELOYXjceNNvn3sPh0an29djKMChU+MpfL8FOllkn687fRyrkVqN1uOPmq7ife/AVG6t+MUp9lYuq4bKLzJhCZ6jmh87P7vr0wHENWnK+XyZ6f2bg4QKIyXtbf9zGAyJmIoo=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <50EC6CBCF34F09408055F389348E0D87@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quantenna.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba8af0bc-d2f3-4cb4-5724-08d70601959a
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SPO_Arbitration_8ec941cc-8ea6-4554-b708-3d99ebe980b5@quantenna.onmicrosoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 13:13:53.1757
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB4609
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-11_02:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015
 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000
 definitions=main-1907110150
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> Add a new NL command, NL80211_CMD_SET_TID_CONFIG to support
> data TID specific configuration. This per TID configurations
> are passed in NL80211_ATTR_TID_CONFIG which is a nested
> attribute. This patch adds support to configure per TID
> noack policy through NL80211_TID_ATTR_CONFIG_NOACK attribute.
> Data TID value for this configuration will be passed through
> NL80211_TID_ATTR_CONFIG_TID attribute. When the user-space wants
> this configuration peer specific rather than being applied for
> all the connected stations, MAC address of the peer can be passed
> in NL80211_ATTR_MAC attribute. This patch introduced
> enum ieee80211_tid_conf_mask to notify the driver that which
> configuration modified.
> Driver supporting data TID specific noack policy configuration
> should be advertise through NL80211_EXT_FEATURE_PER_TID_NOACK_CONFIG
> and supporting per STA data TID noack policy configuration
> should be advertise through NL80211_EXT_FEATURE_PER_STA_NOACK_CONFIG
>=20
> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>

...

> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index ff760ba..4881bfb6 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -281,6 +281,13 @@ static int validate_ie_attr(const struct nlattr *att=
r,
>                 NLA_POLICY_NESTED_ARRAY(nl80211_psmr_peer_attr_policy),
>  };
>=20
> +static const struct nla_policy
> +nl80211_tid_attr_config_policy[NL80211_TID_ATTR_CONFIG_MAX + 1] =3D {
> +       [NL80211_TID_ATTR_CONFIG_TID] =3D { .type =3D NLA_U8 },
> +       [NL80211_TID_ATTR_CONFIG_NOACK] =3D
> +                       NLA_POLICY_MAX(NLA_U8, NL80211_TID_CONFIG_DISABLE=
),
> +};
> +

IIUC, in the current version of the patch set no specific value of
NL80211_TID_ATTR_CONFIG_TID attribute is reserved for 'apply to all tids'
command. It could be left up to drivers. But we need some convention for
userspace tools (e.g. iw) anyway.

Regards,
Sergey