Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4523769ybi; Mon, 15 Jul 2019 10:14:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqynX2ufMAfzZQcCNMzzPzEqCSXYTJ+6E1vuXebj/ZVN8eQBt6clM5ELrj4DFLywXa9ibwA8 X-Received: by 2002:a17:902:b949:: with SMTP id h9mr27385569pls.120.1563210898157; Mon, 15 Jul 2019 10:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563210898; cv=none; d=google.com; s=arc-20160816; b=Ro1f+h6meCVIvytu7R8Qm/i156RwvgN5TkD/xVat8sCFx6bY5jl0a91d42R11y7f5r JKERHqkgvSX1NtkRyEnkZHwAGVFV342+Zx4/ZAL1ZvJjJgOPq+JR54u0MPWgm0fnf83o L/U4e7VjCWEvR7yW+jlZRoYmsYHncGGarbqDEuu7n2sVyjiWsyvlP8KUew0tbr6stdYP SbmiX+NjerdcQk3QRE7HPC1Go7ZyNIs4TizWgPet9hm03/xNbRdGWY588bRDpkzSvDYO +rEM/zVN6Bmt9UQmLnKl2dbp2FmNewfc1PtFZmjjJse5Zq0yw1JRAYCh0DVRY/1rBBVC LKeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=uBujI1LKsX+AicedaFrnsmqG4PdfJMOQIXaxCHAk4rY=; b=qu01fRa8gE7Fw3EFdKsb6Ck1V+RW3Ar8dAA2hkPj9MEAXXS3mb3RH0eNf9zjCWf0/F 634hGbwrF/rT3j01jnt9tqOi480LnO49iqh+CY4aC6FEuNYopeqjiXDrXN995eGsKPcB ra0BepqmBG41vCT49Ys/onxRn/4H08yiorhwHJnW2myNgCEdUKxldxuvxAn11sBaAqon MVZCv7RFVhL/o/SNXNc6bOHi3GrnpgOG1vALHTf43SDKwt/pa9ggMkaFl52/GMwQtarN AHu6pu1kfBZITMKNBgDo6WdP0JEveVaZ/QjoBbC91q0gu3WZgwXwtrOcih4tc5E4C89j 600A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fD8XCw8k; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si4057231pgg.155.2019.07.15.10.14.25; Mon, 15 Jul 2019 10:14:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fD8XCw8k; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731356AbfGORLt (ORCPT + 99 others); Mon, 15 Jul 2019 13:11:49 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42259 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730782AbfGORLs (ORCPT ); Mon, 15 Jul 2019 13:11:48 -0400 Received: by mail-lj1-f195.google.com with SMTP id t28so17030143lje.9 for ; Mon, 15 Jul 2019 10:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uBujI1LKsX+AicedaFrnsmqG4PdfJMOQIXaxCHAk4rY=; b=fD8XCw8k14IG7/yHaD+7mShpN5sKbB7DZx3cF5z8gOZlO6SjOe+uT2FL9cQMzzMRLP EuvXLscSX10HBL36Eu3myWNqmswQPNMoWaQKyd+DDcssimLJ46siZRUSwZhNxnZ93/j3 NWcMN6jC2tKHUi6NVcO4c2bxuH9Nb7Q895XbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uBujI1LKsX+AicedaFrnsmqG4PdfJMOQIXaxCHAk4rY=; b=WWZ9b6kc8WmGdgcsQHeRXHjziHCf+xm7gA2IcChBZvSTQkuphYgfbhW5qN76KWTRWl k4nCrkBoMPivb0sxeLZAEL+q0BQ+T+Y64MSYYMxP7dqHjBI9kTbBQYbX50RFwjLCX0LL 9JwB4W/XTp35dwkYiV2sYMMJf/oNUY56DNvQMml2Yx4OP2ULQNB5S1PQ+iG2A3E8++SQ JKxKfyLemK1KB7Lg4D5cNza984W7kF5Tp9aU6lJ90UbJvvhz0HYd+HtsXUdQcZBNBE12 ANdT/e3bQmDqtRgWfZ2ZXtkdxZwsGEd2ArugQAnE6ZniXtpxqTXHJu4bH523P25b52CH 1tMw== X-Gm-Message-State: APjAAAV/ydLl92Nnar2NJPTgzTOwOn1lUjozwtDgW3iBdZOVOQ8AGx3A oJj1Gies7wlps8rHnMNsRbOECOnrc0A= X-Received: by 2002:a2e:9cd1:: with SMTP id g17mr15076849ljj.234.1563210706651; Mon, 15 Jul 2019 10:11:46 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id h78sm3250921ljf.88.2019.07.15.10.11.45 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jul 2019 10:11:45 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id v18so17030476ljh.6 for ; Mon, 15 Jul 2019 10:11:45 -0700 (PDT) X-Received: by 2002:a2e:b0e6:: with SMTP id h6mr14180325ljl.18.1563210704749; Mon, 15 Jul 2019 10:11:44 -0700 (PDT) MIME-Version: 1.0 References: <20190713013215.215008-1-briannorris@chromium.org> In-Reply-To: From: Brian Norris Date: Mon, 15 Jul 2019 10:11:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] rtw88: make functions static To: Tony Chuang Cc: "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Jul 14, 2019 at 7:24 PM Tony Chuang wrote: > I am sorry I have to NACK it. > > Nothing wrong about this patch. Because in the last patch set I sent has > 11 patches, but one of them is not applied by Kalle. > And I am going to resend it, which will use rtw_get_tx_power_params > in debug.c I suppose that's fine with me. I've marked it as Rejected in Patchwork. (Normally, I would say: it's your fault for leaving these things unused. But it was in the middle of the series, where you were aiming to start using it by the end.) It would still be nice to see the promised v2: https://patchwork.kernel.org/patch/10966403/ Regards, Brian