Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <a266417a71907f663991142f5ce44becc09e6996.1563490117.git.lorenzo@kernel.org>
 <2dffacc1bcbf001d38a173cdce7d141a3dd130a7.camel@sipsolutions.net>
In-Reply-To: <2dffacc1bcbf001d38a173cdce7d141a3dd130a7.camel@sipsolutions.net>
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date:   Sat, 20 Jul 2019 23:29:20 +0200
Message-ID: <CAJ0CqmWCp3fOKM1TdNaMV4KEnd0L3KFFxiBB1tQQeWEvZdAGyw@mail.gmail.com>
Subject: Re: [PATCH] mt76: mt7603: fix watchdog rescheduling in mt7603_set_channel
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        Felix Fietkau <nbd@nbd.name>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

>
> On Fri, 2019-07-19 at 00:50 +0200, Lorenzo Bianconi wrote:
> > Convert MT7603_WATCHDOG_TIME in jiffies rescheduling watchdog delayed
> > work
>
> Seems a bit inconsistent to me, the previous patch for mt7615 used
> jiffies in the define, but here you convert?
>

Hi Johannes,

I personally prefer to define the timeout directly in jiffies (as it
is done in mt76x02) but MT7603_WATCHDOG_TIME is already used in this
way (e.g. mt7603_mac_work()) so I have just maintained the convention.
Anyway we can convert it as well.

Regards,
Lorenzo


> johannes
>