Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8428257ybi; Tue, 23 Jul 2019 08:22:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwa31uWmL94VZ/p3bQmG4sR8zgy2ryUJCMFhJGU2FhHQ/B9RW8v6RHgsct1etlEeC6ko++K X-Received: by 2002:a17:902:d892:: with SMTP id b18mr75895696plz.165.1563895339642; Tue, 23 Jul 2019 08:22:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563895339; cv=none; d=google.com; s=arc-20160816; b=po9v4sr7WDJbOgOySQzvBgUOXHcfepbP4WkAo1IpBmkhLnv8GqVGcgje+Pt9WBwqK8 i0KYfErp48Cb9PmQIp8dDxv2HPUljtpv30hRlkQQM99XrVPEVc3Buy2kyhrxLS30trXc eel8ew+UC3BPmYpmQygYFCffRUt2QwPdvVaPrRCzKkV0P2d2y9w3hxsytEjt+G3EqXsN d7+OzrAuF0wi2eKtCJhcsprSYWRlGItPGp8+6OSzsWunfckOA/CStIILS938wbbG74xh oeYIPv/Gks2UNOySr0sERBzW/3feZFjuFMBcCSNqEQOieQzT+lhwF/3Wfe00dXnMRr3k llIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=LHSHvL2Lv7g6s/8cFNcXYGPBPozgLcAk7Er6Ox2rh5s=; b=wHxj2StQmpbTQCNaWyAo5mZaeZc2fxEaPUbkuGba+WDSHtogiaDSVlp2o18mHO3Z22 1Yq4BmbobTAW0ABEJRInRvmZsRpYdxBk3wK3rqEUMwSVFvufaI/U/Se/LThD4mpNhE4X 87ttRIMVQzsn/nCd79vjbTk/Am7bTOwWIZ7D+vJ4i4AZhjBRW5orfAHCoSU0DF6vusQ5 /sXch+ElrdvK8P9GwjwD565/ej2qUrCECXuVbvUJpwQtZtoobRzPCXITgERXFCX+EKsG qIGuca8z/fPwmdXX96BMG0RrfcahVuoAs8/Csaw91wFUt+tBUJ9YAZk3MZM6xs1L2seC MpWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=A5hc6X5y; dkim=pass header.i=@codeaurora.org header.s=default header.b=bfGBP0te; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb13si39004534plb.325.2019.07.23.08.22.05; Tue, 23 Jul 2019 08:22:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=A5hc6X5y; dkim=pass header.i=@codeaurora.org header.s=default header.b=bfGBP0te; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbfGWIo2 (ORCPT + 99 others); Tue, 23 Jul 2019 04:44:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41372 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfGWIo2 (ORCPT ); Tue, 23 Jul 2019 04:44:28 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CC13B619F2; Tue, 23 Jul 2019 08:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563871467; bh=kxLkewl6Q0I7FEEg5DZ7f85vkdxTUMfxwv/cP5k0pDU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=A5hc6X5yO7V5UiU3S+bl/GseWX/nUvUy++zDnLFXa29aP70vI0agR22onPyXAg9ip 7F6KQCcDUMkLJ8Vc0yjxhCCP+uQpzrFY6w4hT+8hTV74zT5Y1LNdl4tPIQ/L4Q9PBx LUM0bEX/1ggK2wQDLPRGyp1Wb86BuImQ2Jjv+7ek= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3333B619D1; Tue, 23 Jul 2019 08:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563871460; bh=kxLkewl6Q0I7FEEg5DZ7f85vkdxTUMfxwv/cP5k0pDU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bfGBP0tetY8pP6f/42+dnDskyxyBz2Z7A6NaSNlgcj2mcCc6eldKZjp5PAIjaaI1E NTgK9VK3+5hq+5FUk8EakAZ+C6UzOxOKfZDqIYApCe7SRfJc5wZMKTde1UbTxsEk0T nIeI3p6myEvivgORGgyBTpMGl9eKYYBjYa58h1vc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3333B619D1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ryder Lee Cc: Felix Fietkau , Lorenzo Bianconi , Roy Luo , YF Luo , Yiwei Chung , Sean Wang , , Subject: Re: [PATCH 0/5] fix many checkpatch.pl warnings References: Date: Tue, 23 Jul 2019 11:44:16 +0300 In-Reply-To: (Ryder Lee's message of "Mon, 22 Jul 2019 13:31:10 +0800") Message-ID: <8736ixrvhb.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ryder Lee writes: > This gathers many subsets to fix checkpatch.pl warnings. Thanks, this is much better now. > I still keep some warnings there due to readability. > (The most of them are - networking block comments or 80 characters limit) I do the same in ath10k. BTW, here's my simple script which I use to filter unwanted checkpatch warnings etc: https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath10k/ath10k-check -- Kalle Valo