Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9031420ybi; Tue, 23 Jul 2019 20:24:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5q6+a9CWjbFwsQXUwgzzD+GP0K81G6bE/N5ISjXK+ZcNLdLXmS3lho2xZNpqxRZFXL29V X-Received: by 2002:a65:44cc:: with SMTP id g12mr1948295pgs.409.1563938660884; Tue, 23 Jul 2019 20:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563938660; cv=none; d=google.com; s=arc-20160816; b=wlR6cM2TQKzV4spxGD7b1oWKKycrY+OYLJIawTosp8PEUL4wAehm1H9t2hWR3xw4pC QdKoh8wlGK34tUBluXUc9G1EGxYRbZMv8AXUjmutfbQ5gBkiuJtBNBXMvpMH166flHVK XwTmeH7nwD51t4CY3MHCUmSIfl6lZ04Pix3+JMYSCuz6qNXwDDnWspzOjcX/T0YCKxEW jChETTvsErUMmfHXuBC0N2MVucahWJS+YIUmN4eo9p9J40Biuwuo2ESk6WTboG2+4HMy 6JdghyAcvo4PSBpPrx7RjwOavpdRSQxQxGokSrsWeXky/kEZ5tQ990t6A0wie+A8hWHQ CWRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=QeTf2xcw9lNDB9Cy5CEqUviI0IlbE7g1R5a9dV0W5m4=; b=GPTe2TEDCywIEHvBhh0jscFjOHGI6131AaC4q/y9Dv65WiCcVXfN45ICu8khPJ72OF +yYt5zpvw3DqxwQV2pHKnhFEBgioQFdCj+bDFIHGo7vhIOqIJ/IQU1HWJWYfeJKX4Tux R0crIlPhDmvBV9ZD+LYjSkprZMYZddsP5Yn23g/EG+5YLntlRRFbMA+uuycz8q5MfCr0 B/XHXgvygTEhiKz5Yd7JqDf/oDd5xkPA5E1RBvYyLLS19Pd/oxBXaTZxxFC7b2JfMl/6 1RertorjB800rnfbpbKW6m5hC3nFsC6dsFBLN7r8mHg7LeOcCN6VM7viLZpdZWYfhuul vTfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si12633080plq.157.2019.07.23.20.24.06; Tue, 23 Jul 2019 20:24:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbfGXDWt (ORCPT + 99 others); Tue, 23 Jul 2019 23:22:49 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:6817 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725837AbfGXDWt (ORCPT ); Tue, 23 Jul 2019 23:22:49 -0400 X-UUID: bc3b6758d3ff4755bc36f76e05f40f0e-20190724 X-UUID: bc3b6758d3ff4755bc36f76e05f40f0e-20190724 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 347499950; Wed, 24 Jul 2019 11:22:43 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 11:22:42 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 24 Jul 2019 11:22:42 +0800 Message-ID: <1563938562.9134.1.camel@mtkswgap22> Subject: Re: [PATCH 0/5] fix many checkpatch.pl warnings From: Ryder Lee To: Kalle Valo CC: Sean Wang , YF Luo , , Yiwei Chung , , Roy Luo , "Lorenzo Bianconi" , Felix Fietkau Date: Wed, 24 Jul 2019 11:22:42 +0800 In-Reply-To: <8736ixrvhb.fsf@purkki.adurom.net> References: <8736ixrvhb.fsf@purkki.adurom.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-07-23 at 11:44 +0300, Kalle Valo wrote: > Ryder Lee writes: > > > This gathers many subsets to fix checkpatch.pl warnings. > > Thanks, this is much better now. > > > I still keep some warnings there due to readability. > > (The most of them are - networking block comments or 80 characters limit) > > I do the same in ath10k. BTW, here's my simple script which I use to > filter unwanted checkpatch warnings etc: > > https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath10k/ath10k-check > It's really useful! Thanks Ryder