Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9471283ybi; Wed, 24 Jul 2019 04:44:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwaGpZ/W2oZMaF+wnrNWjAzXJAA2sYcHKL0xLzWTxXAX3JEhg/Ol+XfwCMD0zcqZOs5C3Lj X-Received: by 2002:a63:c009:: with SMTP id h9mr53816159pgg.166.1563968673616; Wed, 24 Jul 2019 04:44:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563968673; cv=none; d=google.com; s=arc-20160816; b=fg5oQEeAsi7Va8x1w/qM1nhojkeiERJV7INV2pHYe8Lt6KGdsGqvQ18NvpRKQd//cx vyNkqzkeSg5q/90gHIjDkJ9P+ft1Jqf8VPUy+gR62Wa38n590R8h0eaJczxfP1iYxh+1 tGWgrzGWzAzD6nODA3w0AWjVe+D6yVkV/XJ5SI2YOFvnlJmo43bHnmpwHYk0rVxZcRZB kWOQBmxDPE8HyS/45IRG8g4xJ6VF4MSJcM5p4cJzBAZkCkbYm6nLdx8kLU4NOkx/ltxt ljkFpuxn0DrmXfKm0yoh6g+1OZwMpK5miWJilcP5RWjKcrBz4aT8nHneKSBSiqBv0+lz oTyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=aEYm4I6HOv9icKplJyD+kaJh4aYwFF2XmXVAvpwbJM8=; b=KygdUeTMI0uLdWkBGuGkwnh8kohyZNGLvFwChCNuIUookKmalL95x8gmfvo/t/eaeb ku+iCvrfDeI3TB2koTZH3vdSGt5N86M09U7SttdfwCe2CSk1gvpteu84bCRW7ArNXRVb TWOkVHvavtYguD5TXyJSXungwM+ZIlm4hBab4nv/sUUdbWecneaOQEJ7Hl5ovPKzCyoZ xli5LYFs2tVNwrnvittMYKCl9F4w9mcM0dWugfZrgbdChkJyFHRBffc7JWHUd/OcmCQ5 PHyBHiOVmZok5BH0Xt8U/zsWBKe3Q/kAx45thgu2utWqc0+soJgwlF+UmWNF0UWE4Lny Zrjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jMbf6RhS; dkim=pass header.i=@codeaurora.org header.s=default header.b=LNAY3xDm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si17419646pgj.153.2019.07.24.04.44.19; Wed, 24 Jul 2019 04:44:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jMbf6RhS; dkim=pass header.i=@codeaurora.org header.s=default header.b=LNAY3xDm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727544AbfGXLn1 (ORCPT + 99 others); Wed, 24 Jul 2019 07:43:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43996 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfGXLn1 (ORCPT ); Wed, 24 Jul 2019 07:43:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id ED3A36043F; Wed, 24 Jul 2019 11:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968607; bh=byFzy6X7pbJq+TN7J3RSRYSWZPSaIMEFe5+Gacdf8+8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jMbf6RhSVdlKS5cdyy1s9CEHQLtp3BnhmMZ0/4niIoSR0WbvOKaciXFZGi2YtI+v/ HQQzQrLNe/S0at8eg9V4LGOyr0Bh9XmWD3lGA0O/nGUWE89JJ2B66GzrBUKf4vThDg FboysX+zxHu9ytLSwzEb/FvjW5aOKYWLmHQYsbr4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D725C6021C; Wed, 24 Jul 2019 11:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968606; bh=byFzy6X7pbJq+TN7J3RSRYSWZPSaIMEFe5+Gacdf8+8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=LNAY3xDmVfM3fN9HTzMB6M09awe6/uE/AYEm4IHvwcM8jIkgldz6wnR5HnAjGlQAj cP4UqAAOovPXH/fkY3eZPt4mNFRe+z5tDSs2y5+LqfqU1nRttobjm0wOb44sl/MHPX qN3GxJX7jSDVpwFLOQeyFJv66ULdmgdWZy9MmsNM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D725C6021C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rt2x00: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190703113956.GA26652@kroah.com> References: <20190703113956.GA26652@kroah.com> To: Greg Kroah-Hartman Cc: Stanislaw Gruszka , Helmut Schaa , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190724114326.ED3A36043F@smtp.codeaurora.org> Date: Wed, 24 Jul 2019 11:43:26 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Because we don't need to save the individual debugfs files and > directories, remove the local storage of them and just remove the entire > debugfs directory in a single call, making things a lot simpler. > > Cc: Stanislaw Gruszka > Cc: Helmut Schaa > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. 1dc244064c47 rt2x00: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/11029367/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches