Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9473890ybi; Wed, 24 Jul 2019 04:47:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfmTeyAybaQ2R/+V6X4ikFaw0v4jzWdi/dH+GAFWtTDDH5M6MCuzlwjLbhWUan7GUwbOj6 X-Received: by 2002:a17:902:28e9:: with SMTP id f96mr82068103plb.114.1563968865611; Wed, 24 Jul 2019 04:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563968865; cv=none; d=google.com; s=arc-20160816; b=E4ErsljyY+I/AacBC5vJF7PfSXEuMEFbmpehcAHDQHsZFS2mv4GV/8REOFCdDNQVGL ibqyc0sp82l3dXWP8tLgSkBkrs/lgrugIYD0T+fClpKfsGey0WgVRWW0rKC/+ivgosTZ Zt9/PorYuN8XSC+XosU58+xMCwsihsrXVRpbyExQqnEaXKNFF+qT21OyjQ850kj3i9XI O38IndpFyjrrBzl3bNv0DUuD+j0uD2pUESRJk+oyfoF1XnOr/KKR5DAg3xOigkvnGyUV okWz5S25VAB0bovZdc9i+CAJgoa7sdll9rmfsfHSJhrobWuinRpnSKoW5CLwpGtrg7NZ 41oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=u1ylgmDMMjRgScFvaRdspNff1N3AtVTpmZI4HhK6OVw=; b=Ff7+d0zBSKCy4hrNFKxtJBZiTPYpkIvwy691DSO80EoWgX9laFR4hu83FhGZJ3ltA1 ujIvCH+rSDr/0Pg7s4qrdrvzEpZ0RgcL2LcXI5cOTWzWbz0PoOy8GnDfavihoENFqEfv I1OAijxVO6ZSBWgD4/pHEMOEk4+l37UbR2X0cIkKcYpL57YudzAB+pzJenknBex6UANd /pw2IasVr6gN3HGXBRu5E3aSAPCo6Z5d774RgFMhDLqwEyAs+/H9TyjImUBzpGz3jptJ bkbe5DATIUSKVOrvbjW87PxKaXIperK266PgeE2B6Xce6X6tVaulm/CLRN0Nm5VAIr13 oRxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jUrnCMmi; dkim=pass header.i=@codeaurora.org header.s=default header.b=ka2nhMBT; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si14242498pgt.217.2019.07.24.04.47.26; Wed, 24 Jul 2019 04:47:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jUrnCMmi; dkim=pass header.i=@codeaurora.org header.s=default header.b=ka2nhMBT; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727670AbfGXLqp (ORCPT + 99 others); Wed, 24 Jul 2019 07:46:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48862 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727128AbfGXLqp (ORCPT ); Wed, 24 Jul 2019 07:46:45 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 65BAB60ACE; Wed, 24 Jul 2019 11:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968804; bh=8GMy6D9kKSxX1S2u4a7+1Kw8UopIWsJg3jqvMN3WoMo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jUrnCMmi5Bzem/XphkYN48AykMbjBE+gxZGhIeZd5YJElWWB1+xcV1AZBKx9RDHSP FwI4tOaRBu2aYFqbSd7MMEDSmXJB/J4KuH2mRyoX33z2XumpKhvN4GR93YDq/8kKzf 0RSrgP52YyS4qNOPQGlJc69V7GHyKbYtU75gHHl4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8C7A5605A0; Wed, 24 Jul 2019 11:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563968802; bh=8GMy6D9kKSxX1S2u4a7+1Kw8UopIWsJg3jqvMN3WoMo=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=ka2nhMBTr36hbaZxPYaYrU3WubcNoc3qj3znL2XGpSaBLSlP7Owbk7Z4Kt9cON1pE tmkieEpQG8pVFr/nLYjIbCZGGtjjmpVS0mRp4ARf/n6/zN62oRUQi4tRA5XoPjctDV /mFUHQmlmH3aZQZLIaMDYMljrtgmWh6jgVcF/Yl8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8C7A5605A0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] libertas: Fix a double free in if_spi_c2h_data() From: Kalle Valo In-Reply-To: References: To: Dan Williams Cc: Philip Rakity , libertas-dev@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, Lubomir Rintel , Allison Randal , Dan Carpenter User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190724114644.65BAB60ACE@smtp.codeaurora.org> Date: Wed, 24 Jul 2019 11:46:43 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Williams wrote: > The lbs_process_rxed_packet() frees the skb. It didn't originally, but > we fixed it in commit f54930f36311 ("libertas: don't leak skb on receive > error"). > > Reported-by: Dan Carpenter > Signed-off-by: Dan Williams Failed to compile: drivers/net/wireless/marvell/libertas/if_spi.c: In function 'if_spi_c2h_data': drivers/net/wireless/marvell/libertas/if_spi.c:771:11: error: expected ';' before '}' token goto out ^ ; } ~ make[5]: *** [drivers/net/wireless/marvell/libertas/if_spi.o] Error 1 make[4]: *** [drivers/net/wireless/marvell/libertas] Error 2 make[3]: *** [drivers/net/wireless/marvell] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/11033059/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches