Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9838158ybi; Wed, 24 Jul 2019 10:49:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBD8FlOIVq7KxDIw5mG0UDIWMVmQaWL9Va1KDzfNfJdqHgrbY3qC7PxtF31sl03idaSPDz X-Received: by 2002:a17:902:5c3:: with SMTP id f61mr80774045plf.98.1563990592263; Wed, 24 Jul 2019 10:49:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563990592; cv=none; d=google.com; s=arc-20160816; b=kFdpLAs9UojU4OO9IF67vfYjX4/zvTP5RZtLPR7FjpJHObIhFQ9wXwmvhEGKN7865W kNykB0SMgg8FG1jmsHYD4OMlz/EHtDmvMjg342J2TpsPQtWU0n+8FCM/4BV/Roez1Win fWQjbFy1XqTvLkTKvqT2lNXXX54dfI43C45pwFdMSMNLUA3kJdARfSVEn6hCGveewfGy VpaublRYbs5M3vcuG3uTt2ymfgcTvyA9UsNf+XwMMv/2I/3pEuAOpqtL4USRWUbglQ+W yD3WIARpLCyAWeudrcvBJjNd6MFsglHGilDQ53z2RKWvNHwc1tQRLXz4kpXLHo7qvd7g stKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=gEkDwIuDO2Mlt47g7fHTqzHcSxdtZTDr5XQG+4+AvdU=; b=nkLYGS4kgYr2pkX7i5zAVTFRiPsioJqNqjb5tiJYBDmx2pK64XryjH9OFahS2yGlEp 1dqOVc8uyN3/tPetforbXVr0HBJSW/BHWDiI9XsZYuajMCotdVMHX1SJYxzvII1U1JER wUW+of9IiSrL90A7ZX72ROEYnzT8LLwHf5gMc19tLdcdk7IXCsBELp3BeF7l8+lF+b+B isK9F8YVP4gIECpB2h+wOCFg0vFpEwtLWpbzSUiP3BiFeapfc8lAHUhHpfJ+Itx7hLd4 ozpYtpICrXGALtJVgG2dnhXusTNEF/85Xw4AVp3XrjxBHsTgJNzneSbUBB8WP2hzmmPg KODQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=ntAPjIlL; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si13255045pjl.104.2019.07.24.10.49.15; Wed, 24 Jul 2019 10:49:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=ntAPjIlL; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbfGXRP1 (ORCPT + 99 others); Wed, 24 Jul 2019 13:15:27 -0400 Received: from mx4.wp.pl ([212.77.101.12]:60124 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727238AbfGXRP1 (ORCPT ); Wed, 24 Jul 2019 13:15:27 -0400 Received: (wp-smtpd smtp.wp.pl 7512 invoked from network); 24 Jul 2019 19:15:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1563988524; bh=gEkDwIuDO2Mlt47g7fHTqzHcSxdtZTDr5XQG+4+AvdU=; h=From:To:Cc:Subject; b=ntAPjIlLwGvOxgC2v+xm/bV3mQvMUDMExK5e9IszAZdswFVOM1CMFo9sCJ1pKqGLF kpQZCuccigvIcEx+x1AdexCezOy9xB+tz6O3Y7xqR2h9mmc1Ypn5frAT1xfDiD+D4g 91q1Fzzc/O8xKBgRvC2r2763CVpjRIG6Mu7bIfb0= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 24 Jul 2019 19:15:23 +0200 Date: Wed, 24 Jul 2019 10:15:14 -0700 From: Jakub Kicinski To: Navid Emamdoost Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com, Kalle Valo , "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76_init_sband_2g: null check the allocation Message-ID: <20190724101514.29efc10a@cakuba.netronome.com> In-Reply-To: <20190723221954.9233-1-navid.emamdoost@gmail.com> References: <20190723221954.9233-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 3fa229c2b67e2a6425aaa1fc737c8941 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [EYOU] Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 23 Jul 2019 17:19:54 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Acked-by: Jakub Kicinski Thanks!