Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: brcmfmac: Probing regression in Linux 5.3-rc1
To:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Chen-Yu Tsai <wens@kernel.org>
Cc:     linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
        Johannes Berg <johannes.berg@intel.com>
References: <1563774880-8061-1-git-send-email-wahrenst@gmx.net>
 <96113adb5fcab9c2f4bb5fa82b84ff5f9c07fd07.camel@suse.de>
 <bc650090-db86-ccac-01dc-23f08ad7b19b@gmx.net>
 <20190723093442.GA27239@lst.de>
 <04c5eaa03f3a124dbbce6186e11e19acc4539cc8.camel@suse.de>
 <b15509d6-bc2e-3d06-0eea-943e6e456d62@gmx.net>
 <5f9b11f54c66fd0487837f7e58af3adf7f86635f.camel@suse.de>
 <CAGb2v66-o23CW5iH9Bn1aELymPSiKrA43eJd2q6EZ7iubcogaw@mail.gmail.com>
 <ab7af8537ebcbc7a7bdf04d2c06152ba6821b333.camel@suse.de>
From:   Stefan Wahren <wahrenst@gmx.net>
Message-ID: <3daef629-8baf-3c5c-16a4-73d67604d1e5@gmx.net>
Date:   Sat, 27 Jul 2019 17:17:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <ab7af8537ebcbc7a7bdf04d2c06152ba6821b333.camel@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi,

Am 24.07.19 um 10:37 schrieb Nicolas Saenz Julienne:
>>>> Does it fix the wifi issue too?
>>> Well it works as long as I revert this: 901bb98918 ("nl80211: require and
>>> validate vendor command policy"). Which has nothing to do with DMA anyways.
>>>
>>> Was this the issue you where seeing?
>>>
>>> [    4.969679] WARNING: CPU: 2 PID: 21 at net/wireless/core.c:868
>>> wiphy_register+0x8e8/0xbdc [cfg80211]
>>> [...]
>>> [    4.969974] ieee80211 phy0: brcmf_cfg80211_attach: Could not register
>>> wiphy device (-22)
>> We're seeing this on different platforms (allwinner / rockchip / amlogic)
>> with Broadcom WiFi chips. So it's unlikely to be related with anything in
>> this series.
>>
>> I believe a fix for this has already been queued up:
>>
>>
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9
>
> Thanks for pointing it out, it fixes the issue alright.
>
i cannot confirm. I still need to revert Johannes' commit "nl80211:
require and validate vendor command policy" to get brcmfmac probing on
Raspberry Pi 3B+ and 4B.

The commit "nl80211: fix VENDOR_CMD_RAW_DATA" didn't fix the probing
issue (see warning above).

Regards
Stefan