Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 10:12:11 +0200
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     yhchuang@realtek.com
Cc:     kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
        briannorris@chromium.org
Subject: Re: [PATCH v2 5/5] rtw88: add BT co-existence support
Message-ID: <20190729081211.GB2066@redhat.com>
References: <1564023211-3138-1-git-send-email-yhchuang@realtek.com>
 <1564023211-3138-6-git-send-email-yhchuang@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1564023211-3138-6-git-send-email-yhchuang@realtek.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 25, 2019 at 10:53:31AM +0800, yhchuang@realtek.com wrote:
> +static struct sk_buff *rtw_coex_info_request(struct rtw_dev *rtwdev,
> +					     struct rtw_coex_info_req *req)
> +{
> +	struct rtw_coex *coex = &rtwdev->coex;
> +	struct sk_buff *skb_resp = NULL;
> +
> +	mutex_lock(&coex->mutex);
> +
> +	rtw_fw_query_bt_mp_info(rtwdev, req);
> +
> +	if (!wait_event_timeout(coex->wait, !skb_queue_empty(&coex->queue),
> +				COEX_REQUEST_TIMEOUT)) {
> +		rtw_err(rtwdev, "coex request time out\n");
> +		goto out;
> +	}
> +
> +	skb_resp = skb_dequeue(&coex->queue);
> +	if (!skb_resp) {
> +		rtw_err(rtwdev, "failed to get coex info response\n");
> +		goto out;
> +	}
> +
> +out:
> +	mutex_unlock(&coex->mutex);
> +	return skb_resp;
> +}
> +
> +static bool rtw_coex_get_bt_scan_type(struct rtw_dev *rtwdev, u8 *scan_type)
> +{
> +	struct rtw_coex_info_req req = {0};
> +	struct sk_buff *skb;
> +	u8 *payload;
> +	bool ret = false;
> +
> +	req.op_code = BT_MP_INFO_OP_SCAN_TYPE;
> +	skb = rtw_coex_info_request(rtwdev, &req);
> +	if (!skb)
> +		goto out;
> +
> +	payload = get_payload_from_coex_resp(skb);
> +	*scan_type = GET_COEX_RESP_BT_SCAN_TYPE(payload);
> +	ret = true;
> +
> +out:
> +	return ret;
> +}
> +
> +static bool rtw_coex_set_lna_constrain_level(struct rtw_dev *rtwdev,
> +					     u8 lna_constrain_level)
> +{
> +	struct rtw_coex_info_req req = {0};
> +	struct sk_buff *skb;
> +	bool ret = false;
> +
> +	req.op_code = BT_MP_INFO_OP_LNA_CONSTRAINT;
> +	req.para1 = lna_constrain_level;
> +	skb = rtw_coex_info_request(rtwdev, &req);
> +	if (!skb)
> +		goto out;

Those coex response skb buffers are allocated in rtw_pci_rx_isr(),
but I do not see where they are freed (seems we do not process
them in c2h_work which does dev_kfree_skb()).

Stanislaw