Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jul 2019 08:34:04 +0200
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "briannorris@chromium.org" <briannorris@chromium.org>
Subject: Re: [PATCH v2 5/5] rtw88: add BT co-existence support
Message-ID: <20190730063403.GA3174@redhat.com>
References: <1564023211-3138-1-git-send-email-yhchuang@realtek.com>
 <1564023211-3138-6-git-send-email-yhchuang@realtek.com>
 <20190729081211.GB2066@redhat.com>
 <F7CD281DE3E379468C6D07993EA72F84D1881C82@RTITMBSVM04.realtek.com.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D1881C82@RTITMBSVM04.realtek.com.tw>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 30, 2019 at 03:13:35AM +0000, Tony Chuang wrote:
> > Those coex response skb buffers are allocated in rtw_pci_rx_isr(),
> > but I do not see where they are freed (seems we do not process
> > them in c2h_work which does dev_kfree_skb()).
> 
> You're right, that SKB leaked. Should free them after responded.
> I will send v2 to fix it :)

FWIW maybe would be better to process coex commands entairly in
c2h_work ? Not sure if that would work or really would be better,
just an idea you can consider :-) 

Stanislaw