Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5791726ybi; Wed, 31 Jul 2019 03:25:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyx6Q3SG7MlBWMszK3SUQMthBH26W4xiGvEuo4LfjNzFSBWtmg9Fl36ez5ANmt3yXpLJPlQ X-Received: by 2002:a17:902:d90a:: with SMTP id c10mr116925154plz.208.1564568714363; Wed, 31 Jul 2019 03:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564568714; cv=none; d=google.com; s=arc-20160816; b=DlAYI5uiFwy1RSX/T6GHkONc64UpANiAtVp3ZFTofMJmxnJpH8YUBuyNe0Ar4ys0p2 Lcoup4yRmo+b8Ch4MCbFwPL6PGvCeXk/nrXBdcCcKmJqtFI7aLCW0bGbgyicaap8l3DV RJkccCBY0pdVoNaEhLI09mOonttmB3Ry4sQ+vLHrUq/PPA+D3dnDMcgpQbSVDhhtHe1n m4sn/NBGVEN6WDWlDQWkOV/eJDOkY9hxnCuWKCfpkEC434RhQLwcwMhrAt4WVBXaqB6U 1uMVecmWrDmEb3HwvGUfvQsBVTvr+eyuuVpr5QdXEbIoNU091tcBsQL8MY2W4wIhWTel Gvvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=B0Jw65bN43Ht4QZZALH51UqYWMLdv4VNQfdr0HQeFn0=; b=XJqefXL9DPozmm4ZS0ImtC+kcuJZQZ3aOv80g7v1dK5DTbKwr8MhWZGhrpIvP76Ft6 FxaoU7fXDabND8eKmtduHU3uuyeT6tdKL1oq5wIrtUD21RBUj7IaRmynGN8SA8EVewUR /hBr9EzBB2tZ1Zf18dtHpym42cNbA7LPnq2a4LmzukREK5d664gbppYuy2NIZJCHBqMl sww3YhogA212TU6ZlwrvbwESOg45q9oAWcGqo9MKV64UjVj8VX0QSN8Cfl4kZic8koby 1JD+gT3cxzGNV68/NaUcCm9VzjDWIkcbgKnyv346OA60mo0viO/voHSzlKV1QYQRHGj6 g6yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20si1244119pjn.27.2019.07.31.03.24.41; Wed, 31 Jul 2019 03:25:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbfGaJeM (ORCPT + 99 others); Wed, 31 Jul 2019 05:34:12 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:55604 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbfGaJeM (ORCPT ); Wed, 31 Jul 2019 05:34:12 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hskzo-0004lO-Sc; Wed, 31 Jul 2019 11:34:08 +0200 Message-ID: <7aa18e9e89743f3b4a188c8e677aad203a3ef2db.camel@sipsolutions.net> Subject: Re: [PATCHv6 6/9] mac80211: Add api to support configuring TID specific configuration From: Johannes Berg To: Tamizh chelvam , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Wed, 31 Jul 2019 11:34:07 +0200 In-Reply-To: <1560835632-17405-7-git-send-email-tamizhr@codeaurora.org> References: <1560835632-17405-1-git-send-email-tamizhr@codeaurora.org> <1560835632-17405-7-git-send-email-tamizhr@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote: > > @@ -1626,6 +1635,14 @@ struct ieee80211_vif { > > bool txqs_stopped[IEEE80211_NUM_ACS]; > > + int noack[IEEE80211_TID_MAX]; > + int retry_short[IEEE80211_TID_MAX]; > + int retry_long[IEEE80211_TID_MAX]; > + int ampdu[IEEE80211_TID_MAX]; > + u8 rate_ctrl[IEEE80211_TID_MAX]; > + u32 rate_code[IEEE80211_TID_MAX]; > + u8 rtscts[IEEE80211_TID_MAX]; This is quite a bit of data (176 bytes), can we make it up to the driver to store it if supported, instead? > @@ -2004,6 +2027,13 @@ struct ieee80211_sta { > > struct ieee80211_txq *txq[IEEE80211_NUM_TIDS + 1]; > > + int noack[IEEE80211_TID_MAX]; > + int retry_short[IEEE80211_TID_MAX]; > + int retry_long[IEEE80211_TID_MAX]; > + int ampdu[IEEE80211_TID_MAX]; > + u8 rate_ctrl[IEEE80211_TID_MAX]; > + u8 rtscts[IEEE80211_TID_MAX]; same here. > +static int ieee80211_set_tid_config(struct wiphy *wiphy, > + struct net_device *dev, > + struct ieee80211_tid_config *tid_conf) > +{ > + struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); > + struct sta_info *sta; > + int ret; > + > + if (!sdata->local->ops->set_tid_config) > + return -EOPNOTSUPP; > + > + if (!tid_conf->peer) > + return drv_set_tid_config(sdata->local, sdata, NULL, tid_conf); > + > + mutex_lock(&sdata->local->sta_mtx); > + > + sta = sta_info_get_bss(sdata, tid_conf->peer); > + if (!sta) { > + mutex_unlock(&sdata->local->sta_mtx); > + return -ENOENT; > + } > + > + ret = drv_set_tid_config(sdata->local, sdata, &sta->sta, tid_conf); > + mutex_unlock(&sdata->local->sta_mtx); > + return ret; > +} and you're not actually using the data anyway? johannes