Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4039306ybh; Tue, 6 Aug 2019 05:26:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzK7Un+7lfqeHpm01jk/gjSMt/Nh+CjkhjlK0NPZrREu4DJAPEqQE7KOcdlBRPSqRSiVa7w X-Received: by 2002:a62:3347:: with SMTP id z68mr3512000pfz.174.1565094371289; Tue, 06 Aug 2019 05:26:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565094371; cv=none; d=google.com; s=arc-20160816; b=cBp5CtVHpy/hLWokFKU93FlDL8QTtFCxuz9teMFvyE3PynbMs8E9EN3rOztekf9u6O 6kPPPveUTqTRzpNKKAsrm2OwbaLJdpstENzgLecEOzdKX+0HbAmOvhnF8pnrc9wU2Lwo mFl3uLufcluKlskB8X96SRPaFIXj9PQZGTlbzJzrW6X1O2tMUcFLt+GzPcCHZ3zWjvKu G6RM8FzEiKAPV08djApPAnr/fT2lUBxk7GPi8/FbjpEEvc4FmNwrF8QYhugOsOOJCs+y sCesSYHn7+vB4dI/00Yq0o4D/Vy+41ZuU9tXpN1CJeWaUqnlQErTUqAMcSpOmt7gFLce 6YEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=z/Ra9YLij8l3CxCXL8gf65ibATMq689s8hRosUb1sZA=; b=pfLt3+b7XfTc8C3Ox9zWfo/YSrtB3mtzE5CfigBboc9MILqem7AZZLUlhqlyNt15Gh N2jxzghG/HHD5U6LgDeoEKNP7CowTBIbTj5EbNMcRJgBlQ2k9wMU9G6Z+/lRwis4VmAi +/Xc3fUkrbJlJNRUxwDey+DaOj8kJGh/zV7BHciF5svsqwnIHXk9x0rzY9q9cEUWlf3b pidHitOXiZfuHjctw+tZzFKa7Pxy8b9lUqlaL2sqtJoep9oyIdMoD3SpnQipFqYJoIUq TbMhLDrJHoGNq2JnmpD78b81pReM4+0u8RW9md8ltu+nhLKmEiKAXZkjexC9Dqe3Kj05 C56g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QejDs9ks; dkim=pass header.i=@codeaurora.org header.s=default header.b=oGQzhpTA; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x13si51071074pgf.275.2019.08.06.05.25.45; Tue, 06 Aug 2019 05:26:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QejDs9ks; dkim=pass header.i=@codeaurora.org header.s=default header.b=oGQzhpTA; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbfHFMZT (ORCPT + 99 others); Tue, 6 Aug 2019 08:25:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54386 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfHFMZT (ORCPT ); Tue, 6 Aug 2019 08:25:19 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 01947608CC; Tue, 6 Aug 2019 12:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094319; bh=ca1LOVDmRVvP70xkzyWoS5J/M4KpZeq3R2plRp/fxxY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=QejDs9ksjnVzZcbG4qdpVIKR8VL/+dTLxdf9m079lGt/8ttZdb3JG/1CVOUwkjHWo Unrw8hto5FTD2WY6eut43sgiQtcDFeyik5yM+/WF6KMap+Kkd9Xz7T2BNauYBvJV9b q2XC+iXCh2Mn1ezVPI6zaMfe/g442fg0U+Lbgc78= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8958B60452; Tue, 6 Aug 2019 12:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094318; bh=ca1LOVDmRVvP70xkzyWoS5J/M4KpZeq3R2plRp/fxxY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=oGQzhpTAnWOkcNiJh6L7AEk+Rdd1FmCMMndk6IAunv0wzC9YB16Ku3oMRWZowWrfe 7PUodzv3LgPhynggcrW/hbCjW1ISzvbLs4+1ltKOntLGCZMnoT/NwlWXNwZ/5g2Q/K fYX398HyNQgzYZi4p48wGeI2gOedu+5Ntnonb6zU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8958B60452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays From: Kalle Valo In-Reply-To: <20190713013232.215138-1-briannorris@chromium.org> References: <20190713013232.215138-1-briannorris@chromium.org> To: Brian Norris Cc: , Yan-Hsuan Chuang , Brian Norris User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806122519.01947608CC@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:25:19 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > We're just trusting that these tables are of the right dimensions, when > we could do better by just using the struct directly. Let's expose the > struct txpwr_lmt_cfg_pair instead. > > The table changes were made by using some Vim macros, so that should > help prevent any translation mistakes along the way. > > Remaining work: get the 'void *data' out of the generic struct > rtw_table; all of these tables really deserve to be their own data > structure, with proper type fields. > > Signed-off-by: Brian Norris Patch applied to wireless-drivers-next.git, thanks. 3457f86da60d rtw88: use txpwr_lmt_cfg_pair struct, not arrays -- https://patchwork.kernel.org/patch/11042813/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches