Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp4051263ybh; Tue, 6 Aug 2019 05:36:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4tHgv/YZyUpTQFWpWwKcs8qOuv4lSR59aie8yrah8+tzSvqx0O1vCSt2at1+KOxrmlGD6 X-Received: by 2002:a17:90a:d817:: with SMTP id a23mr2968230pjv.54.1565095009150; Tue, 06 Aug 2019 05:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565095009; cv=none; d=google.com; s=arc-20160816; b=EUouL0tDv6Peu0q+/F9eyVXODnD9bVqZnGWKHK/iVPIqRES5X6cUbh2/42X4lcIV2i LY0GWJ6FQQQwBTPFpwFF9fJsNZmr4ZpZ2rXxRYDLdX5RiKXpZo722Hef8VhUKivdScVo iAZTvSTCk+HMdI/ZGG7uynSQlHrn82CBUJBwsSYrkBkJLNVv0QEW2G+IKc/aILL3By4N U/ItuRl49DGcAYczW2VriQuj0MEVNcxz20R1qLa8gJuM0hg6U5feeqaK2/Tu1FbNFD9J lSz45NaDv4PtZSr7kgfaH+rIg/G6+je7rASDBVvPE3FwFFbsCHML9mtgkqUA4N+OC2EH fP5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=okf7HT8ytb+XJ8mIHNAEqqMtyz/F7/oTDf+QvgqbPfo=; b=DID99kW5AGoVmFcM5XeV2K6V44DbKshvu+ggXWtSxaI43eNXa7MtzFRyfdulP5hSHS RKV6D0feqfsoDyvyI8Il/48osAmqiogJYVvKwfICKFXip9SB3A+UykKgcFXbL4sixheV CZ+lhIfczPs0xqeXWz+t90aiLI4x5mjf7HYFCeg4mjJ6fsBndhHD+vlUI+b+iy40ObNk ECYucKNqLjKIedPtgrjL9rfjadEL9d6KmKnwHf84HOjOWN8dmzbDr9Ri7Y7G8KJuBdF4 AYI8+yv6mCIHYiFJ0KsmdQenSkQzb1b0ZYGLmajJt8QMwpNtu86LowVPQyawKlzmotkC HNKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="n/NFR8e6"; dkim=pass header.i=@codeaurora.org header.s=default header.b=Dg5fiiKl; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h31si30913570pgb.67.2019.08.06.05.36.34; Tue, 06 Aug 2019 05:36:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="n/NFR8e6"; dkim=pass header.i=@codeaurora.org header.s=default header.b=Dg5fiiKl; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728797AbfHFMgU (ORCPT + 99 others); Tue, 6 Aug 2019 08:36:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60238 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfHFMgU (ORCPT ); Tue, 6 Aug 2019 08:36:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 30B4260EA5; Tue, 6 Aug 2019 12:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094979; bh=bj8qWGpk0Sk8b4h8M0Ne5LXuOnmgHgbZr/8RgDNfuP8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=n/NFR8e6uXdTOcxgC4FYIIvCgEMowGv40S/7M0PSyT6SAGCDRg5MGpGmHuGvm5vBh ib6wt+geuP1GBMibxUhUmrV5qC+dfT6HiJmaCnT/f3C/tfGhfeXiF7MzTSqOK1zVx6 OFcFpbc7JEHrWCTHa2aPrw/8e1HnVod+towgJzWI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B25CB608BA; Tue, 6 Aug 2019 12:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094976; bh=bj8qWGpk0Sk8b4h8M0Ne5LXuOnmgHgbZr/8RgDNfuP8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Dg5fiiKl+2LFh3I+pWjL092hV7TngoKzborRoN74EW4KRcpbs+nwMTI6RVw1whISe sPqJUsINYQRPWt+aFM0DPXndUOosh3IOcu4Fslc/8GUp6RGiElz9h/0mTAg33nr+qA eo5CGPUblez1eRYjIdhjMH6gQwrd835cZBPv1BHU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B25CB608BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] libertas: Fix a double free in if_spi_c2h_data() From: Kalle Valo In-Reply-To: <9153261627a0f84b996e023f1349a2bc06dd03ee.camel@redhat.com> References: <9153261627a0f84b996e023f1349a2bc06dd03ee.camel@redhat.com> To: Dan Williams Cc: Philip Rakity , libertas-dev@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, Lubomir Rintel , Dan Carpenter , Allison Randal User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806123619.30B4260EA5@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:36:18 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Williams wrote: > The lbs_process_rxed_packet() frees the skb. It didn't originally, but > we fixed it in commit f54930f36311 ("libertas: don't leak skb on receive > error"). > > Reported-by: Dan Carpenter > Signed-off-by: Dan Williams Patch applied to wireless-drivers-next.git, thanks. 3915a252ce71 libertas: Fix a double free in if_spi_c2h_data() -- https://patchwork.kernel.org/patch/11057049/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches