Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp5075972ybh; Wed, 7 Aug 2019 00:00:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqw543Ix27v/h4jMsbXdzc8tFm9sD25W1ADj8/y/fmPOfR+8reqA2NokdIsEqt3qk2oTE4Xi X-Received: by 2002:a17:90b:949:: with SMTP id dw9mr6993292pjb.49.1565161226674; Wed, 07 Aug 2019 00:00:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565161226; cv=none; d=google.com; s=arc-20160816; b=L5FsPElSLAq+wwIYV0fYBhcsU0tHJNbKpqLvlKz4EFJ0yPGM0pPKlZfYfxR2OhnIP/ jXrZa7bnC8kuSGxhbmH1mFkMGEc1ynq7jeOVs/yutbIcvgirr0gKMnCC6Ijb43PTrwnC E8LTs1A7TeyvmsFYfP82BTLOQwkGwUdCVlDjgzZaB2s4a8Z/bLu3j/w50BzhVyrQEUq5 IyfZ6wJLkYbyjfF1XFfP+SN89At0+qyEkFvOG+reIWbFuCo9uAjL7zOFV23H6fE1mUCD +ufREBVuHQ7XbujYcvtEuiU4+9+RB6hlpJEHYSZ7Qkw4E5I0fsCzDUiSKwZkNshRi60V pr/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=C0WbIGzN7QMIchpce1loyLDyh7y1tlawxQLyNOhSCK0=; b=FIqti9kB8CeRS2HI9y0vAmLp9y7n3gXrlYyp3fFek6EvdyJDIs/K6jppEk3//7BkV3 bHcT+HPts+UtIFNyEia7zKJCL87bcGismEeTjjGqxT6XbNgPJdCiPqF2r6IkkPrxZ9+t o6VpjmPhircvnGIh+w1kRgzqWPe9s/OKkahXdRnVvVz6vOGz81PaphXdZBtoP9igvxak Bm+pN8FxSC1PlU+RbKUXOl28C7MVRxB+Jhz4jZ1PrMgpcfyARGtfOMxvhMp57rTlOml9 qIVHZejyE9pCZOCZ1eMwZ2C9w/KnPxH/eZdIErpofRMoh7bNq0rUWWRYLKBPpirGQi5W xViQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=qCPIAesM; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 39si52501498plc.99.2019.08.06.23.59.59; Wed, 07 Aug 2019 00:00:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=qCPIAesM; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbfHGG54 (ORCPT + 99 others); Wed, 7 Aug 2019 02:57:56 -0400 Received: from nbd.name ([46.4.11.11]:59552 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbfHGG5z (ORCPT ); Wed, 7 Aug 2019 02:57:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C0WbIGzN7QMIchpce1loyLDyh7y1tlawxQLyNOhSCK0=; b=qCPIAesMMtjDSR9JyhCvt4p4us grylcXqTyBN/nsiwNfMlim6zPQgLPB/d2HGrP/fajzW4j7RK+n2BqxgNzjfcwOQsGVG8HClJI00W9 lHcXpuInjz17050jMukEPWJsV+XKzxd0LyGRD+dZ4Pn/tYHmxeQkQGkIBZi9N/YP1YDo=; Received: from p54ae9719.dip0.t-ipconnect.de ([84.174.151.25] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hvFtP-0001G6-EE; Wed, 07 Aug 2019 08:57:51 +0200 Subject: Re: [PATCH] mt76: move mt76_tx_tasklet in mt76 module To: Lorenzo Bianconi Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org, ryder.lee@mediatek.com, royluo@google.com References: <527fdc4e453cbc1408500625c0080d9c59d9e1dd.1565112514.git.lorenzo@kernel.org> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: Date: Wed, 7 Aug 2019 08:57:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <527fdc4e453cbc1408500625c0080d9c59d9e1dd.1565112514.git.lorenzo@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-06 19:31, Lorenzo Bianconi wrote: > Move mt76{15,03}_tx_tasklet in mt76 module since it is shared between > mt7615 and mt7603 drivers > > Signed-off-by: Lorenzo Bianconi I think it would be nice to get rid of the EXPORT_SYMBOL_GPL for mt76_tx_tasklet by moving the tasklet_init call to mt76_alloc_device(). That way, dev->mt76.tx_tasklet will be set to mt76_tx_tasklet by default, but automatically overwritten for drivers that have custom implementations (76x02 / usb). - Felix