Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <527fdc4e453cbc1408500625c0080d9c59d9e1dd.1565112514.git.lorenzo@kernel.org>
 <e83840e9-06cf-bab9-ed3e-954e3f03c083@nbd.name>
In-Reply-To: <e83840e9-06cf-bab9-ed3e-954e3f03c083@nbd.name>
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date:   Wed, 7 Aug 2019 11:53:05 +0200
Message-ID: <CAJ0CqmWOh+oQ3_1mdpoKkDeiRCd5pOCrfk-GfL1qRYEyX1zRjQ@mail.gmail.com>
Subject: Re: [PATCH] mt76: move mt76_tx_tasklet in mt76 module
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

>
> On 2019-08-06 19:31, Lorenzo Bianconi wrote:
> > Move mt76{15,03}_tx_tasklet in mt76 module since it is shared between
> > mt7615 and mt7603 drivers
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> I think it would be nice to get rid of the EXPORT_SYMBOL_GPL for
> mt76_tx_tasklet by moving the tasklet_init call to mt76_alloc_device().
>
> That way, dev->mt76.tx_tasklet will be set to mt76_tx_tasklet by
> default, but automatically overwritten for drivers that have custom
> implementations (76x02 / usb).
>
> - Felix

ack, I agree. I will fix it in v2. Thanks.

Regards,
Lorenzo