Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1565167700-22501-1-git-send-email-yhchuang@realtek.com>
 <1565167700-22501-2-git-send-email-yhchuang@realtek.com> <3307e4b7-c92d-e1d2-b896-26e45fb69a9b@broadcom.com>
 <F7CD281DE3E379468C6D07993EA72F84D188A068@RTITMBSVM04.realtek.com.tw> <7bbbe3be-1f6f-8f38-45f3-54f25a5b2f38@broadcom.com>
In-Reply-To: <7bbbe3be-1f6f-8f38-45f3-54f25a5b2f38@broadcom.com>
From:   Josh Boyer <jwboyer@kernel.org>
Date:   Wed, 7 Aug 2019 12:20:44 -0400
Message-ID: <CA+5PVA4LDjCtPW8HAve79inmihT_6BDp899HGx_7P-4U3H7NaA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] rtw88: RTL8822C: add WoW firmware v7.3
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     Tony Chuang <yhchuang@realtek.com>,
        "linux-firmware@kernel.org" <linux-firmware@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        "briannorris@chromium.org" <briannorris@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 7, 2019 at 6:15 AM Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
>
>
> On 8/7/2019 11:53 AM, Tony Chuang wrote:
> >> From: Arend Van Spriel [mailto:arend.vanspriel@broadcom.com]
> >>
> >> On 8/7/2019 10:48 AM, yhchuang@realtek.com wrote:
> >>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >>>
> >>> Add WoW firmware to support entering Wake on WirelessLAN mode
> >>>
> >>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >>> ---
> >>>
> >>> v1 -> v2
> >>>      * update WHENCE file for new added firmware
> >>>
> >>>    WHENCE                    |   1 +
> >>>    rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes
> >>>    2 files changed, 1 insertion(+)
> >>>    create mode 100755 rtw88/rtw8822c_wow_fw.bin
> >>
> >> Just wondering: Is this a good approach? What firmware should distros
> >> pick? Is there a trade-off affecting other wifi functionality when using
> >> WoW firmware?
> >>
> >
> > If distros want to use WOW, they should pick both.
> >
> > For Realtek devices such as RTL8822CE, it needs to "change/re-download"
> > the wow firmware to suspend with WOW functionalities. When resume,
> > switch back to normal firmware to run "normally".
> >
> > I think the reason is the firmware size restriction. For newer devices,
> > maybe there is a larger space for firmware, and we don't need to swap
> > the FW like this :)
>
> Interesting approach and I would mention this in the commit message or
> add a README in rtw88 folder explaining it. Not sure whether distros
> look at commit messages.

A README would indeed be nice.  Can you do a v3 with that included?

josh