Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp49760ybl; Fri, 16 Aug 2019 18:30:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8SVvHAgsorVNFk3Uz885zhnTR5yCYy9RkDxZdU+86QPv2SXOuKEkPZboLs6aMhgL4ZrBK X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr9857354pji.122.1566005438676; Fri, 16 Aug 2019 18:30:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566005438; cv=none; d=google.com; s=arc-20160816; b=N/saDhyJwFACyo1gcf+6B1VAOENvPqFNDZgPeIyDRFqbjQFomEzuU/GlKraJ3/VIXq WW2F/HP9KutY+OAh8W2NEuGf43QCT9cgO6AI1gP9/f+IWEadcrokvko09rnCDFWau0Hw F8ZfVUwS4kRb43GFK+awe0LCQcc1HNJ2xJ2HOwoEdlb70YgLPCjig8lkFAL/vmh7jC6R ui6yD4FuYgPI+sSViTnmaGvQBVIN7w0RhkwyOU2jRUee3qeaj7Jh5yBcVU22VanEPkHk Ev9MZTzSiq08iwwFfpVKuxtecEx3kOPY+tPOzcJigTpCNXBnbRhSlfzuEZ/vjV47Lxgs AM2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=l5zP82JIYM+AT8kTl8ZmKqYDGrjqjh9d+SLlcon2/QI=; b=MiSvnQoitENWgJDUvoiaI5LeWwl68iNtmA7lZKyemSmpQodXjnMy0zZnTHot5KYMdM ji4XRq7w0qx50e88XfpN9lj2ua/H3QoTZ2mtp1EBD8RlfirC55mSP3qeDDPzTfxlBaZ3 xHuVaFsMpg47BVN2eCSZQy5pRq7o1iJFJIFocpxWFpwPTbp5hHmyATy1ErZxjGJGyQyP Uqevw1r4XIeYlUzU/OpTAD9W1D26et4eacNTrVN4sQzUVZ4d3u7P/AkFs5UoDO/hV+7j cjaxQjcwjOSSluwNb/5e9ndVxefWzG40QONQIqb/o0CIcqH8MKqpqknb1XFsjJ10sMbw e2Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TZYT4xz7; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si5012359pgn.160.2019.08.16.18.30.05; Fri, 16 Aug 2019 18:30:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TZYT4xz7; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725988AbfHQB37 (ORCPT + 99 others); Fri, 16 Aug 2019 21:29:59 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35600 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfHQB37 (ORCPT ); Fri, 16 Aug 2019 21:29:59 -0400 Received: by mail-lj1-f195.google.com with SMTP id l14so6839477lje.2 for ; Fri, 16 Aug 2019 18:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l5zP82JIYM+AT8kTl8ZmKqYDGrjqjh9d+SLlcon2/QI=; b=TZYT4xz78WrPzadsQM99gC83MiiDHBheOTOyqzQwC6FLLt8yKfHks971YWhfqPp3N2 IIhLRW73hxVqQZEjIfzKn9Scb9Wifx991UouIuNn1bkM2EQlNWRQ9Wc6OUHOPvYnKlMY DNd6Z+/CUao+9rblo8g6Go9PiJoGncYvrrAik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l5zP82JIYM+AT8kTl8ZmKqYDGrjqjh9d+SLlcon2/QI=; b=jMZ3//k0lsIsY+eyZbxoiLc29oNfEFJNsBBfHVF0biLRZGM1K7f6BgT0/hIgNrmjRu 2MaLf5DQhMm2zZzZ5tBqbkDkfkcI8GEuP08WMMeJzDDZndpDTqpMrkM0gX4yd+E5VwXR DNdJmFRTrCQ90SL13j6lf4+SjBWYQ4duJ+8zASzrhVYx9FvPYK6hHk9so6oM+p99WF/I Hm/whpAQYwzsUiauuTRyFJ2JJs6l9VO6VZUz3s0GxvRSyZXbtDsshGM709lUzO0zPwZc lfsFMZhFRUoQdbeC5UlWut3J3m5TNeLiHHZr+vQlvyuY2oWUg9A7oCNNBnHdeM6zyTOi m+6A== X-Gm-Message-State: APjAAAUSdjaNdc17nczO3+dnvbgoxMVKe79UzOBERkmgrMexUMSHe0IV RzvVAA4Eggqz7ZFxuepT42JYQ1cQ3tk= X-Received: by 2002:a2e:5c8:: with SMTP id 191mr7017478ljf.241.1566005396427; Fri, 16 Aug 2019 18:29:56 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id m23sm1207786ljh.97.2019.08.16.18.29.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 18:29:55 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id x4so6822743ljj.6 for ; Fri, 16 Aug 2019 18:29:54 -0700 (PDT) X-Received: by 2002:a05:651c:1135:: with SMTP id e21mr6947295ljo.83.1566005394425; Fri, 16 Aug 2019 18:29:54 -0700 (PDT) MIME-Version: 1.0 References: <1564575767-27557-1-git-send-email-yhchuang@realtek.com> <1564575767-27557-3-git-send-email-yhchuang@realtek.com> In-Reply-To: From: Brian Norris Date: Fri, 16 Aug 2019 18:29:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/3] rtw88: enclose c2h cmd handle with mutex To: Tony Chuang Cc: Kalle Valo , linux-wireless , Stanislaw Gruszka Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Aug 15, 2019 at 7:45 PM Tony Chuang wrote: > I think the problem here is I should give a better comment to better > describe the usage of the mutex. And I also want to keep it short. I don't think we have limits on comments in source code -- better to document too much than not enough. Brian