Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 2/2] nl support for dmtool
To:     Alexei Avshalom Lazar <ailizaro@codeaurora.org>,
        Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
References: <1566137719-3544-1-git-send-email-ailizaro@codeaurora.org>
 <1566137719-3544-3-git-send-email-ailizaro@codeaurora.org>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <a1edb82d-6bdb-a44d-4781-c05358fffad9@broadcom.com>
Date:   Mon, 19 Aug 2019 10:20:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1566137719-3544-3-git-send-email-ailizaro@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 8/18/2019 4:15 PM, Alexei Avshalom Lazar wrote:
> Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>
> ---
>   drivers/net/wireless/ath/wil6210/Kconfig   |  11 ++
>   drivers/net/wireless/ath/wil6210/Makefile  |   1 +
>   drivers/net/wireless/ath/wil6210/ioctl.c   | 245 +++++++++++++++++++++++++++++
>   drivers/net/wireless/ath/wil6210/netdev.c  |   8 +
>   drivers/net/wireless/ath/wil6210/wil6210.h |   1 +
>   include/uapi/linux/wil6210_uapi.h          |  77 +++++++++
>   6 files changed, 343 insertions(+)
>   create mode 100644 drivers/net/wireless/ath/wil6210/ioctl.c
>   create mode 100644 include/uapi/linux/wil6210_uapi.h
> 
> diff --git a/drivers/net/wireless/ath/wil6210/Kconfig b/drivers/net/wireless/ath/wil6210/Kconfig
> index 0d1a8da..48b14de 100644
> --- a/drivers/net/wireless/ath/wil6210/Kconfig
> +++ b/drivers/net/wireless/ath/wil6210/Kconfig
> @@ -53,3 +53,14 @@ config WIL6210_DEBUGFS
>   	  option if you are interested in debugging the driver.
>   
>   	  If unsure, say Y to make it easier to debug problems.
> +
> +config WIL6210_WRITE_IOCTL
> +	bool "wil6210 write ioctl to the device"
> +	depends on WIL6210
> +	default y
> +	help
> +	  Say Y here to allow write-access from user-space to
> +	  the device memory through ioctl. This is useful for
> +	  debugging purposes only.
> +
> +	  If unsure, say N.

I was about to scream in horror seeing this patch, but noticed you 
rectified it in v8. *Phew*

Regards,
Arend