Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5bc077f7b2f017da7c027edd27a543910dd6ac32.camel@sipsolutions.net>
Subject: Re: [PATCH] iwlwifi: Extended Key ID support for mvm and dvm
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexander Wetzel <alexander@wetzel-home.de>,
        luciano.coelho@intel.com
Cc:     linux-wireless@vger.kernel.org, linuxwifi@intel.com
Date:   Mon, 19 Aug 2019 22:09:14 +0200
In-Reply-To: <52914e64663283eeff9445b8b1fb37986c15223d.camel@sipsolutions.net> (sfid-20190819_220332_573678_41D0461A)
References: <20190819180540.2855-1-alexander@wetzel-home.de>
         <204c346ab9fc71865e4cb5f5c29ec33ca05050e2.camel@sipsolutions.net>
         <da471544-3370-8ba1-2265-d02ab09cdcee@wetzel-home.de>
         <52914e64663283eeff9445b8b1fb37986c15223d.camel@sipsolutions.net>
         (sfid-20190819_220332_573678_41D0461A)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-08-19 at 22:03 +0200, Johannes Berg wrote:
> 
> > While less desirable we still could get that working: The mvm driver 
> > would have to detect the key borders and then tell the firmware to 
> > switch over to the other key. But we would have to make sure to not 
> > re-enable A-MPDU aggregation till the card really has switched.

> So probably you're right, and we'd have to disable A-MPDUs until we have
> no outstanding old-key-retransmits, but that seems manageable.

Actually, we probably have to even delay the key switch until there are
no more frames to retransmit, because the hardware is involved to some
extent and it won't know about two keys or something... Not really sure
how it all works though, off the top of my head.

johannes