Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, pkshih@realtek.com
References: <20190812192741.14479-1-Larry.Finger@lwfinger.net>
 <20190820140836.6727960E57@smtp.codeaurora.org>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <8b4f8edf-fd73-2b88-b985-22658840f409@lwfinger.net>
Date:   Tue, 20 Aug 2019 10:36:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190820140836.6727960E57@smtp.codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 8/20/19 9:08 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
> 
>> In the process of converting the bit manipulation macros were converted
>> to use GENMASK(), the compiler reported a value too big for the field.
>> The offending statement was trying to write 0x100 into a 5-bit field.
>> An accompaning comment says to set bit 3, thus the code is changed
>> appropriately.
>>
>> This error has been in the driver since its initial submission.
>>
>> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> 
> I only see patch 5 on patchwork, what happened to patches 1-4?

I pulled them at the last minute, but forgot to rename the subject. Please apply 
that fix alone. The others will follow when I get time; however, they are code 
improvements. Only this one was a code fix.

Larry