Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4536572ybl; Tue, 20 Aug 2019 13:35:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFqhn1DXTEt6Lk2FbRmXM6bBcVEn9gWsZdkoeBJqGj0xoyvg7S7Bgfoa5WlyzcakPjY00a X-Received: by 2002:a17:902:2ae9:: with SMTP id j96mr20260647plb.38.1566333336890; Tue, 20 Aug 2019 13:35:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566333336; cv=none; d=google.com; s=arc-20160816; b=V47gPKdTRJQqHBHZTRBHuyh6c6kgNx2TvMGdsnH+KN+ZMBrSJBYsCoBNpDVCcYRyuy BDGAbM9e5gnMChFdhVF55fPfpQihIqEPyd81D+wkFXFak+lWAKALzbbipb9Zx0HPJw6i ItU3c3/H3DsFj5ZO18gshqjyslg7WOTX7HyDhT3rCOLopr6PXRx4hq/keR+K9i+SIWfi UY1S7dCyqgpVIMyfTMK8bWQNHCvrJysoMTWuDzIHKYsjRtuqDsdV/re7UyqHK5Gc/gHO GDA1zsZ9TX/IMc27oZTaBMktoOgSsJ20kHsPFMr6WvhfvPzi4AbK082FxMD6HhJKOyz1 3S2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=H8RZFFyRzemgoyF2SQL7PAUNVIRZn6Nl2IM5LSsU+uM=; b=w/cD4hU1FSVEDs4+i4bgALrEU4wsz7As8W5WtiYkGKOrunEz7D2vdcEezNcZiYqmn9 VFhuthUZJIDERRpJItQcvvwBbHwFxbr7xqL1OqilryunRoYI5z4342Fk2GqUXmsZ6CLQ k1jjKd0H7/rLgm2I9MDnzr/i6FFJw+vQyUHmkcdqkRdI7ATdQWkfz2djYhY+VwUfNJYt v4ot8XuqQ3+Q1o5Q6zE5BSaAZ2+IRNmmwscyyd3tQpaiFzDnJ4qQrd1vsTVZRGRhkc8z iKnxPjnq+G526FzU7f7SYq/Q4/y2UoyEwXT2arNzklCpK4CHoDMVmJTw0eIs5t3KmTal uKqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e66si12823819pgc.197.2019.08.20.13.35.07; Tue, 20 Aug 2019 13:35:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730931AbfHTUcw (ORCPT + 99 others); Tue, 20 Aug 2019 16:32:52 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:43574 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730501AbfHTUcw (ORCPT ); Tue, 20 Aug 2019 16:32:52 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i0AoB-00084G-HX; Tue, 20 Aug 2019 22:32:47 +0200 Message-ID: <0c526ce00e6e1c7731c990515e7438230efb55af.camel@sipsolutions.net> Subject: Re: [PATCH 08/49] ath11k: add core.c From: Johannes Berg To: Kalle Valo , linux-wireless@vger.kernel.org Cc: ath11k@lists.infradead.org, devicetree@vger.kernel.org Date: Tue, 20 Aug 2019 22:32:45 +0200 In-Reply-To: <1566316095-27507-9-git-send-email-kvalo@codeaurora.org> (sfid-20190820_175156_803421_4FF79584) References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-9-git-send-email-kvalo@codeaurora.org> (sfid-20190820_175156_803421_4FF79584) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > +module_param_named(debug_mask, ath11k_debug_mask, uint, 0644); > + > +MODULE_PARM_DESC(debug_mask, "Debugging mask"); > + > +static const struct ath11k_hw_params ath11k_hw_params = { > + .name = "ipq8074", indentation here seems a bit too much > +MODULE_LICENSE("Dual BSD/GPL"); All your files state "ISC", shouldn't that be reflected here? johannes