Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC 0/1] Allow MAC change on up interface
To:     Dan Williams <dcbw@redhat.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        James Prestwood <prestwoj@gmail.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <20190815185702.30937-1-prestwoj@gmail.com>
 <645af7dad899e8eb186b3fee0f8a8a151a408557.camel@sipsolutions.net>
 <394092a2f20697c9b055166a8254a5ef888551a5.camel@gmail.com>
 <4848c3a9d0b330fab4442436244387a2c127fa03.camel@sipsolutions.net>
 <c6b719d6279211bbf52443f327884d96ef63f2b2.camel@gmail.com>
 <6835732fcc59ba8dbbcda4abc6e17dad499a7d8d.camel@sipsolutions.net>
 <b115e933-a357-9904-e831-dea7df1b46b9@gmail.com>
 <3576ad937c0b40b971a1b9c1a7c7396731a94bad.camel@sipsolutions.net>
 <8c04da29-7515-1196-8431-67a6390bc00d@gmail.com>
 <3fd41591acd55535863f11a0cc4f0f5f2afd5bdf.camel@sipsolutions.net>
 <3313f0a7-2b38-9941-46bf-4c1a3e06a267@gmail.com>
 <3beb3208443d39201272e822d26c1389aa4940db.camel@redhat.com>
From:   Denis Kenzior <denkenz@gmail.com>
Message-ID: <86a8b422-87e3-5ab7-40fe-604969ec8ec1@gmail.com>
Date:   Tue, 20 Aug 2019 16:52:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <3beb3208443d39201272e822d26c1389aa4940db.camel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Dan,

On 8/20/19 4:18 PM, Dan Williams wrote:

<snip>

> 
> Code will be written, but I'd rather it be written once rather than 3+
> times for STA/AP/Mesh/etc.
> 

I'm not sure you can state that definitively just yet?  So the real 
question is whether saving the extra round-trip to the kernel is worth 
the in-kernel complexity.  Given that interleaved system calls are 
_always_ a problem, I argue that it is worth it for at least the Station 
case (and it will keep connection times even faster to boot).  Isn't 
minimizing the latency of connections the end goal here?  I get that 
there are trade offs and people have other opinions on what a good trade 
off is.

But don't misunderstand, either solution is better than what we have 
today.  My argument is: "why close the door on a particular solution 
until the costs are known?"

>> The rest, I'm not sure why you are worried about them now?  For
>> station
>> there's a very clear & present use case.  If such a clear and
>> present
>> use case is presented for AP or Mesh, then deal with it then.
> 
> Why would you not want to pass a random MAC for AP or Mesh modes? The
> same reasons for MAC randomization apply for all those too, I'd think.

Umm, I was not arguing against doing that at all?  All I said was that 
no such use case was yet presented.  For AP it isn't typically needed to 
rapidly switch between MAC addresses while keeping the device UP.  If 
you think there's such a need, I'm happy to learn something new? Same 
goes for Mesh really?

> 
>>> I don't see how this will not keep proliferating, and each new
>>> thing
>>> will come with its own dozen lines of code, a new feature flag,
>>> etc.
>>
>> Such is life? :)
> 
> Not really. It's the job of maintainers to balance all these things, to
> step back and think of the bigger picture and the future rather than
> just solving one particular use-case today.
>  > Your tone leaves the impression you want a particular solution pushed
> through without the normal planning/architecture discussions that
> accompany API changes. And that's not how the process typically works.
> 

So who's attacking who now?  We're trying to solve a long standing issue 
that nobody has bothered to fix for years in a clean way.  Something 
that one of your projects would benefit from, btw.

I have a technical opinion about how it should look like.  Johannes 
might have a different opinion.  In the end it is up to him and I can go 
pound sand.  So yes, I know how the process works ;)

Regards,
-Denis