Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190817041258.GA1641@chirva-slack.chirva-slack>
 <87y2zsf9ps.fsf@depni.sinp.msu.ru> <20190817214448.GB1070@chirva-slack.chirva-slack>
 <1b1e573e6502c97851838a3b27ac0b272198926c.camel@intel.com>
In-Reply-To: <1b1e573e6502c97851838a3b27ac0b272198926c.camel@intel.com>
Reply-To: sedat.dilek@gmail.com
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Wed, 21 Aug 2019 08:49:15 +0200
Message-ID: <CA+icZUU6nX7KVir1CFBxZuVB-aHzw-QETKpDEwVsJD_X=1v1bg@mail.gmail.com>
Subject: Re: PROBLEM: 5.3.0-rc* causes iwlwifi failure
To:     Luciano Coelho <luciano.coelho@intel.com>
Cc:     Stuart Little <achirvasub@gmail.com>,
        Serge Belyshev <belyshev@depni.sinp.msu.ru>,
        Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        linux-wireless@vger.kernel.org,
        Haim Dreyfuss <haim.dreyfuss@intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 20, 2019 at 12:45 PM Luciano Coelho
<luciano.coelho@intel.com> wrote:
>
> On Sat, 2019-08-17 at 17:44 -0400, Stuart Little wrote:
> > After some private coaching from Serge Belyshev on git-revert I can
> > confirm that reverting that commit atop the current tree resolves the
> > issue (the wifi card scans for and finds networks just fine, no dmesg
> > errors reported, etc.).
>
> Sorry for the delay in responding, I had to go and dig in our FW
> sources to see what was going on.
>
> Unfortunately when this feature was implemented in the FW, we forgot to
> add the usual flag (capabilities TLV) that we add to let the driver
> know whether the command is supported or not.  So we need to match on
> the FW version instead, but apparently that doesn't work for all
> different NICs.
>
> I'll have to look into all NIC/FW-version combinations that we have and
> update the iwl_mvm_sar_geo_support() function accordingly, which is,
> BTW, the easier place for you to change if you want to workaround the
> issue.

For the records (here: Linux v5.2.y)

"iwlwifi: Add support for SAR South Korea limitation"
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.2.y&id=2b9d99b399d5e4cd516973a4c56035fb0e2ee744

- Sedat -