Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp665146ybl; Wed, 21 Aug 2019 03:47:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHqOorqX8EBoKgMRJOyItAkZ/mKAb9Ay9BzDR7W0di15z+ZyV68yYNoNONDFQNNDgUlUTC X-Received: by 2002:a65:68cd:: with SMTP id k13mr28477002pgt.411.1566384427313; Wed, 21 Aug 2019 03:47:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566384427; cv=none; d=google.com; s=arc-20160816; b=vkZRZDayfA78BUQuezi3j1Lv3cL8fBP/INJf63YLNoQrzGP7TmXmk8BfVN/I61zo7m /Dsf2/meF8DZgKMInUBmJVOYf6Xxcf9LauRBx9F0Sh4APR33sDpRcLtSGD8aZ8x9K4fj +anMb4TMn6lEWWvNvVBlbC/1E3yunnULE/e+ygHfuWwjtj1yfzfPSjHSzAX/iZcZm3KA f/ilh+Tr4C7K3oMRR53i3srPb8ZHrfP70JfUSp+Aw9Mb/og/aTodGBiwyeIA4yme0RwF sKO1MD8p09HawekqMVdfzaSYhnPOd+fLyNRZlsohvSV9uVzXHUFx2cI2lkMk6Zs6FvA2 htmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:references:cc:to:from:subject :dkim-signature; bh=zk1OZ4AZxMZIHmxBRMpz486j7h5k1iWmCFDX+hGXK+o=; b=r6sPZH4cPqTYC45sDhTxE9nakrhvkhzUJ/HL7BSomJEoD0x4bMLYvztiVphq4U9Zjy hlR1eoRpQ0pI6L8Zhir+dl+Ml/Q2SmmcyPAp6y6eRgv7Jo4Ym8nZYHQSzte88a8a0+DB ayzpxrtjvZqqUBRcOoEXu5cqz84+H/Z81W9maPbszCdgpKNm5Rg/MCAS1uOLBGoLij/a L6Ah5uy9YIweJHrDpMa5aYbrYLTkP1MmWEtEeC1wGU4vHTkE1m2mNb5k4v8vxTa/vHjK zNhH2RM2cCrxe3O2I3KnOq6IaJZL6PpcdCYRH603Lh71nskHL0A0pQe1DRX4g50Lh870 57mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=LrBITJSp; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si14386085pll.343.2019.08.21.03.46.44; Wed, 21 Aug 2019 03:47:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=LrBITJSp; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727058AbfHUKkS (ORCPT + 99 others); Wed, 21 Aug 2019 06:40:18 -0400 Received: from nbd.name ([46.4.11.11]:35850 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbfHUKkS (ORCPT ); Wed, 21 Aug 2019 06:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zk1OZ4AZxMZIHmxBRMpz486j7h5k1iWmCFDX+hGXK+o=; b=LrBITJSp791dXNqswLKgcKVnch 8sUWIeZxWfRedwjasZjPdoRKeD5ErBVIGcbyiUBBHZZBEGhJ428r7YcBaELAV9pDwDbh7ozEXeDc+ ybZ/lahmPOdVXbJJJUUnUEP3ylF9awRbzCIF2t1CNA1G5bqiZrZAqKeVtzz/6kkmA9X4=; Received: from p54ae9443.dip0.t-ipconnect.de ([84.174.148.67] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1i0O2J-0005ko-Et; Wed, 21 Aug 2019 12:40:15 +0200 Subject: Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E From: Felix Fietkau To: Stanislaw Gruszka Cc: Lorenzo Bianconi , linux-wireless , Ryder Lee , Roy Luo References: <1565703400-10623-1-git-send-email-sgruszka@redhat.com> <20190815100936.GA21775@redhat.com> <727fd528-16c1-e3b3-e1a9-2edbcbdddee7@nbd.name> <20190819110639.GA6037@redhat.com> <7b46ab63-d69d-f389-b3c2-245cbe11c7b7@nbd.name> <20190820112438.GA2227@redhat.com> <20190821084724.GB20223@redhat.com> <433c1d1f-3590-375f-ed8d-c9de2af873d5@nbd.name> Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <876a4137-ecd5-2e6c-0c75-87eae895e672@nbd.name> Date: Wed, 21 Aug 2019 12:40:14 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <433c1d1f-3590-375f-ed8d-c9de2af873d5@nbd.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-21 11:03, Felix Fietkau wrote: > On 2019-08-21 10:47, Stanislaw Gruszka wrote: >> On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: >>> > Can you test if disabling hw encryption only for shared or only for >>> > pairwise keys makes any difference? >>> >>> Disabling only pairwise keys helps. Disabling only shared keys does >>> not help. >>> >>> Not sure if this will be helpful information or make things more >>> confusing, but seems the difference between mt76_txq_schedule() >>> and tasklet_schedule() in mt76_wake_tx_queue() is that on >>> mt76_txq_schedule() some tx packets are serialized by dev->rx_lock >>> (because some ARP and TCP packets are sent via network stack as response >>> of incoming packet within ieee80211_rx_napi() call). Removing >>> spin_lock(&dev->rx_lock) in mt76_rx_complete() make the problem >>> reproducible again with mt76_txq_schedule() & HW encryption. >> >> So, I think this is FW/HW issue related with encryption and ordering >> and we should apply patch originally posted in this thread that >> disable HW encryption for MT7630E. >> >> I do not think we should disable HW encryption only for pairwise keys, >> because FW/HW can have the same bug for shared keys, but is not >> triggered in my test, as we do not sent lot of group frames. > I'm still not convinced that this is just the hardware implementation of > hw crypto being faulty. I think it's more likely that there's a bug in > the tx path somewhere, which causes hangs on MT7630E but remains hidden > (or at least recoverable) on other devices. > I'm currently reviewing key handling in the mac80211 fast-xmit codepath > and get the feeling that something might be racy there. > I will let you know when I make some progress with that review. > If we can't find the bug soon, then I'm fine with merging this patch. > Right now, I would like to see first if we can fix it properly. Another question: Does a watchdog restart happen before tx fails? - Felix