Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp421244ybl; Fri, 23 Aug 2019 02:58:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhN0KWzqjhPX6lmXBb0OZ/pYc8+A/z5B5w5HgsW2sCylazF0iiTmlRASzWrPiAObkkCpJV X-Received: by 2002:aa7:9483:: with SMTP id z3mr4309562pfk.104.1566554291813; Fri, 23 Aug 2019 02:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566554291; cv=none; d=google.com; s=arc-20160816; b=K5o31pmJiwfwCATT/mhAqruiAKDsIeXFk11ZFJYOg1PIrwJeC6dMKQ/cuVbb8HeWiV GmIKGflvgVTD14heE9gRFtRC/QNfY6rEq9k5Ljq3Hgn9xvHOtd4SoB45yqRaw2tIBwD+ vvlDk6Y3FSsSMXn8RB1OJvTZxNI20AaUHSSlql7E6OjQyn3po7Vr3pl4JuqqJdJfpwPf mz0kZvzKF3/vKLzWoCYv2N/cu3dlqf+IS90F/EyLBrYIrdEfgKAdGaIZl+Xobk/JBY6g tVv5ANq/Wgioh/yWDz+xTT0tNZG1YVjUPGhirrDUQruOPbwITCZwFrQK5UJnry2WB6Ui bPoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id; bh=ELANnvMjknKGBDN9jlpWBfKl5Y8cYaBZ/FoeGskwg4A=; b=to3T9zG4s2+Sz5vs/xlrPgSqdLvZedtbsc7O1cxtV0M29zlUBkDBxwdrEzEysbFwm+ I7kZ1pUu5jqvctFN8HusR2IuB8LbHlqm4MjGXnkzL7s0YKnetl1V2ZTznXUnnB8auXE6 4DIU66Vl7ELjNVoKyAGzFaxEOQM9V+lUxiqg5ic/3KZ/S0Rjep0H6xMwiZgOXsy8QK1c xveDnz7xFybonLUHRKOqkovXEezssVBRyR4IYZCsdwtgeXQJIYDSWEqsNFFDwDAQBTpS ZWkYmmFsbURS+EOLvBPys0aRZ/jR63TTYePoZkDHV3sbmZyuIeuaZrQw1zNcgGEA9SJ6 gusg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si1525997pgt.217.2019.08.23.02.57.57; Fri, 23 Aug 2019 02:58:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391937AbfHWFRm (ORCPT + 99 others); Fri, 23 Aug 2019 01:17:42 -0400 Received: from mga17.intel.com ([192.55.52.151]:38604 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391807AbfHWFRm (ORCPT ); Fri, 23 Aug 2019 01:17:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 22:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,420,1559545200"; d="scan'208";a="186777188" Received: from pkacprow-mobl.ger.corp.intel.com ([10.252.30.96]) by FMSMGA003.fm.intel.com with ESMTP; 22 Aug 2019 22:17:40 -0700 Message-ID: <84a882c0bd2954c21735005534abb5568b2fc806.camel@intel.com> Subject: Re: [PATCH] iwlwifi: mvm: fix old-style declaration From: Luciano Coelho To: YueHaibing , johannes.berg@intel.com, emmanuel.grumbach@intel.com, linuxwifi@intel.com, kvalo@codeaurora.org, sara.sharon@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Date: Fri, 23 Aug 2019 08:17:39 +0300 In-Reply-To: <20190726141838.19424-1-yuehaibing@huawei.com> References: <20190726141838.19424-1-yuehaibing@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-07-26 at 22:18 +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get a warning for this with "make W=1": > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning: > 'static' is not at beginning of declaration [-Wold-style-declaration] > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:434:1: warning: > 'static' is not at beginning of declaration [-Wold-style-declaration] > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- Thanks! Johannes applied this in our internal tree a few weeks ago and it will reach the mainline following our usual upstreaming process. -- Cheers, Luca.