Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp421333ybl; Fri, 23 Aug 2019 02:58:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvbmklq0K3pyqwXPga4pzaEo7kP/WXs1voJaUfnunHOenKWFSjO43spnrEWsDoQsLqdDT9 X-Received: by 2002:a17:902:aa03:: with SMTP id be3mr3807839plb.240.1566554298172; Fri, 23 Aug 2019 02:58:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566554298; cv=none; d=google.com; s=arc-20160816; b=SoOFdirwW2d57JklCMl9HZGh59IJhmcRr0rkkSWMo4BnBRSqx70Zmjz7PTMIrcwNy5 vE+01cSb2H5R6rHLiGE6uJBICtILemMxd2mhmPaE8/zMlTitJdq12cdFl9gaCwNaoPXR ZpV5pjK3000VZbBlKDCa0dcANXOq0oIi6itUihRLPlNs7Ecyitwink5YsrpeHRKO+m77 nrCHSlOc6KgJTZuv0Mz9TFzKokylyaIhFbI9kRaLy5zQiQT4/Ec8roZ3u4fNYDx1EWse coRg16p9ZBO4Fe+pKl58CS5iS31XjlVsdppJA1x5ZljEna1u8k97GmhU4xm9ZP/d858a qEqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:user-agent:references:in-reply-to:date:to:from :message-id; bh=76OMXC51knO7NY3/cKAfZGYovrk6SDkOZVRNL2pALeY=; b=ooQfDZoCknP5EYXJBD7p8r8pxDeZ3o/eKNYSrobSiqGXtNf58lSGC580N0TRQMARQd TeGMSYurDDyf1p76P554qZzlWORhtu13CTwuaBWIn7Wiyo3avS3XepkpN3LNtJmZyW9j MechttxEwlXH+wIMJsl9gNE0qUBSOwSQlivBiF7sT6JFYAyB/aiafnV1TdCpUaIgfmmI RjstS+AGusMyXa5kDKWrGDUs50EMdsOUEQ/9ZH6iVdKP8peKF8Zlm+afaHrSRf1uW0lX 3+s6jyQwAHBS8jekPOIkiWUwEMvFWBI+6oBvI35lwsU3UI3nNEJ0AiUo2KacDKtFhJh4 EB4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o131si1578618pgo.445.2019.08.23.02.58.04; Fri, 23 Aug 2019 02:58:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392036AbfHWFXt (ORCPT + 99 others); Fri, 23 Aug 2019 01:23:49 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:38256 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2392030AbfHWFXs (ORCPT ); Fri, 23 Aug 2019 01:23:48 -0400 Received: from [91.156.6.193] (helo=redipa) by farmhouse.coelho.fi with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92) (envelope-from ) id 1i1238-0003kO-KB; Fri, 23 Aug 2019 08:23:47 +0300 Message-ID: From: Luca Coelho To: Wang Xuerui , linux-wireless@vger.kernel.org Date: Fri, 23 Aug 2019 08:23:45 +0300 In-Reply-To: <20190223083543.6009-2-wangxuerui@qiniu.com> References: <20190218150952.6889-1-wangxuerui@qiniu.com> <20190223083543.6009-1-wangxuerui@qiniu.com> <20190223083543.6009-2-wangxuerui@qiniu.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH] iwlwifi: mvm: fix unaligned read of rx_pkt_status Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, 2019-02-23 at 16:35 +0800, Wang Xuerui wrote: > This is present since the introduction of iwlmvm. > Example stack trace on MIPS: > > [] iwl_mvm_rx_rx_mpdu+0xa8/0xb88 [iwlmvm] > [] iwl_pcie_rx_handle+0x420/0xc48 [iwlwifi] > > Tested with a Wireless AC 7265 for ~6 months, confirmed to fix the > problem. No other unaligned accesses are spotted yet. > > Signed-off-by: Wang Xuerui > Tested-by: Wang Xuerui > --- Thanks! I have applied this to our internal tree and it will reach the mainline following our normal upstreaming process. -- Cheers, Luca.