Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1244581ybl; Fri, 23 Aug 2019 16:05:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFOuH5wGuJ1ZFt1SWrwFWHAvTwivRJgplXXeTdBZge8mAorVYtHsjqx6NMX5LwwoBTW7Ou X-Received: by 2002:a17:90a:fa95:: with SMTP id cu21mr7874326pjb.43.1566601520622; Fri, 23 Aug 2019 16:05:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566601520; cv=none; d=google.com; s=arc-20160816; b=kVp9RvOMqSGcd3taEyz6iRnbyMxC+0Dzhah08sUd2oz4ub0rpOmJAYLggsuIoLhBSw mQyrfy46zODWJtCWEv0Nn+QEW33Ynddsv0NvC6kYwfq4yM7hcjOFUjIzJPxZNzC2jbRc SawYVtdDmrCMAxMiKXHUBSAiaLoEAp8nb7tLL5HdiILeablwQY9QfD7DMttM80i3SQoC pwU1v6bT4XFS2psvt6RtgZEDDKARYqjPciEq8kGKkqvvWWREzrjUOQ/rfOL0y5+2Ts9Y HTIr53XGQUl4DO7P8suMMp7ws+TMumBDawtBlnrklwArX4HQrCrUfBN7o7mt19W4gMzA HDsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=LAv14xBDaIohDD4Erb5BrR+vAz31vPo/+adgvMu/7MI=; b=OeUNREuT6OhF1Q6iEKhzRVgTfh4GCZ4EscjdC8IhSq0NyytGsy+g1mT7VAebRjV3Y2 XQuX+YCqCYPGlBrosecY0f1O77JWi6l6iNH7tib/3uRFqIxSBGJnTkHSTPs/3nyN05JO 3v+ppmw4dMsSFhejTQuEkXDFPjwfRqjHflkGlyISC7Ppwn4tBSRr9Ivcz0GPbqmunBc8 r7FXKsHhDrqtGvg66GgpRpYbMz7rufb4gYkOhuRd+nrOgkjmcsWQf+kB5R8Gg4iISXVK UeVVzsNVUTKuhrZEqfTaubWJGFn8dgBehCVPIr12GbOIDbZlZbpm+Az34ivEN8M5wHKn zA7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=WTTeFnBG; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 70si3878630ple.282.2019.08.23.16.05.06; Fri, 23 Aug 2019 16:05:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=WTTeFnBG; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390567AbfHWLHn (ORCPT + 99 others); Fri, 23 Aug 2019 07:07:43 -0400 Received: from nbd.name ([46.4.11.11]:50230 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbfHWLHm (ORCPT ); Fri, 23 Aug 2019 07:07:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LAv14xBDaIohDD4Erb5BrR+vAz31vPo/+adgvMu/7MI=; b=WTTeFnBGKMij/9WAFwDZZNzF/l MZhKH7Q5CiuYF/JbZXYqsh+5Xro6Xdbvd2+WDyE4PbxiqqJkalSn2ELmivO8QVSTSGZfsDsUWx7V8 psfREPo2Cp8c/TrZvzeL1uqyEHUGavDIg267Vx3+/9lQf9GkFC6oXJZ+rZyk6k6U66CM=; Received: from p54ae9443.dip0.t-ipconnect.de ([84.174.148.67] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1i17Pu-0005Ev-QB; Fri, 23 Aug 2019 13:07:38 +0200 Subject: Re: [PATCH][next] mac80211: minstrel_ht: fix infinite loop because supported is not being shifted To: Colin King , Johannes Berg , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190822122034.28664-1-colin.king@canonical.com> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: Date: Fri, 23 Aug 2019 13:07:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190822122034.28664-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-22 14:20, Colin King wrote: > From: Colin Ian King > > Currently the for-loop will spin forever if variable supported is > non-zero because supported is never changed. Fix this by adding in > the missing right shift of supported. > > Addresses-Coverity: ("Infinite loop") > Fixes: 48cb39522a9d ("mac80211: minstrel_ht: improve rate probing for devices with static fallback") > Signed-off-by: Colin Ian King Acked-by: Felix Fietkau Thanks, - Felix