Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1313123ybl;
        Wed, 28 Aug 2019 12:45:14 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwE8HQesQb1+/wZBrzsX4tG4qHd/6x4GEwrG6vlExCg7JtTqBhwnvnuGUxVZGt56bGTwVFy
X-Received: by 2002:a62:6801:: with SMTP id d1mr6562750pfc.117.1567021513970;
        Wed, 28 Aug 2019 12:45:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1567021513; cv=none;
        d=google.com; s=arc-20160816;
        b=CBcbQynB9v/d9pxTX5aRzF4A66pR4Pl4BAv3ACOErD6QBieDLaLKXE+LRCPk+rpVOw
         7nsudzRrAFM1likflx7Qe1SPnsJ0M/xjoG9uyhENuanw7TkPdi/NX7JNbJS+n2RCARH7
         QrwnN08eeGRLVbv6VaoVg14vPuYQkVYKV0dmm0/c8L2SWi8RCL1W1LVlaEkG0mN+b6M3
         oLPL5Yw4hqU89xcMNoHfDCU/AiEvurEAPex+jUj67eYyRLq3qiMwpP3/N7ge9F8OfkCg
         m9PDWQUFhYt/M7xdtS2rLylj+iZHYD/nnHOFI6mfIhjvy2pBMYz0pHADJ1suoDE1Id8Q
         VmIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :user-agent:references:in-reply-to:date:cc:to:from:subject
         :message-id;
        bh=rWdxP91rydGTMpYphQT7W/4Y7fP8ILowZ5dTuBy8LDA=;
        b=jYH2LGVW9ewh8JF7udnk2xrsrMeir//k+e6BVjEOT7NAQv1BJdAQx7fnkIflPsghYP
         3MO/NOcLr/gaDkW9W9VddkXL9k5rsSB0UKjQZB02mIGDwA9QvHAzOXGyvXeyAg0103hX
         HaYSoMDrBdveHzVXvuyMPeftzYNUYqUjOAliJgCQTbMNMyUGW8aXO5ePx8egqdn0Vv2C
         6Z9ZpyCGJfGIwW7Hb08bUx43CX8QXfeOjKjT+LryrbJqcNjgW2c9be1GaXzzlBvSLwqs
         9PAoS9D9N7FWK3Sk1ME6C8WXyoOWrux6R0luoLHolasDg+u3R3mAEiTY8xgtNwxtXipY
         GbsQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w11si32533pgr.321.2019.08.28.12.44.43;
        Wed, 28 Aug 2019 12:45:13 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726617AbfH1Toc (ORCPT <rfc822;prestwoj@gmail.com> + 99 others);
        Wed, 28 Aug 2019 15:44:32 -0400
Received: from s3.sipsolutions.net ([144.76.43.62]:41002 "EHLO
        sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726603AbfH1Tob (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Wed, 28 Aug 2019 15:44:31 -0400
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.92.1)
        (envelope-from <johannes@sipsolutions.net>)
        id 1i33rk-00079a-Hx; Wed, 28 Aug 2019 21:44:25 +0200
Message-ID: <18c4232675c7b4f13fbfe9e5d8e9364a0908f316.camel@sipsolutions.net>
Subject: Re: [PATCH v2] cfg80211: add local BSS receive time to survey
 information
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Marcel Holtmann <marcel@holtmann.org>, Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 28 Aug 2019 21:44:22 +0200
In-Reply-To: <9189B2C1-6E5B-4457-9354-A010F946EE33@holtmann.org>
References: <20190828102042.58016-1-nbd@nbd.name>
         <9189B2C1-6E5B-4457-9354-A010F946EE33@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Marcel,

> ... [snip]

Please trim quotes a bit.

> > 	NL80211_SURVEY_INFO_PAD,
> > +	NL80211_SURVEY_INFO_TIME_BSS_RX,
> 
> wouldn’t this go before the PAD attribute?

No, as usual, that would break ABI. PAD is a regular attribute, just
empty and ignored for aligning 64-bit values.

johannes