Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 30 Aug 2019 11:03:37 -0700
From:   asinghal@codeaurora.org
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     johannes@sipsolutions.net, jouni@codeaurora.org,
        linux-wireless@vger.kernel.org, jjohnson@codeaurora.org,
        rmanohar@codeaurora.org
Subject: Re: [PATCH] cfg80211: Convert 6 GHz channel frequency to channel
 number
In-Reply-To: <544cab9b-8914-370d-c8a9-407ce88f6f32@broadcom.com>
References: <1567117290-19295-1-git-send-email-asinghal@codeaurora.org>
 <544cab9b-8914-370d-c8a9-407ce88f6f32@broadcom.com>
Message-ID: <eced13d4e91dee3f5ad82a2278ef7af5@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2019-08-30 03:45, Arend Van Spriel wrote:
> On 8/30/2019 12:21 AM, Amar Singhal wrote:
>> Enhance function ieee80211_frequency_to_channel by adding 6 GHz
>> channels.
> 
> This look very similar to what I submitted earlier:
> 
> https://patchwork.kernel.org/patch/11073197/
> 
> Regards,
> Arend
-	else if (freq <= 45000) /* DMG band lower limit */
+	else if (freq < 5940)
  		return (freq - 5000) / 5;
+	else if (freq <= 45000) /* DMG band lower limit */
+		/* see 802.11ax D4.1 27.3.22.2 */
+		return (freq - 5940) / 5;

hi Arend,
           I see a small issue in your patch above; for frequency 5940, 
the channel number returned would be 0 which is an invalid channel. I 
guess 6 GHz center frequency numbers begin with 4945.

rgds,
Amar