Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1567407757-26951-1-git-send-email-yhchuang@realtek.com>
In-Reply-To: <1567407757-26951-1-git-send-email-yhchuang@realtek.com>
From:   Daniel Drake <drake@endlessm.com>
Date:   Mon, 2 Sep 2019 18:34:36 +0800
Message-ID: <CAD8Lp44L06OAXvoP=jU9Tt0YgfWrRmTN0v4Jq_gjxrOTYn5XwQ@mail.gmail.com>
Subject: Re: [PATCH v3] rtw88: pci: enable MSI interrupt
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        =?UTF-8?B?SsOhbiBWZXNlbMO9?= <jano.vesely@gmail.com>,
        Linux Upstreaming Team <linux@endlessm.com>,
        Brian Norris <briannorris@chromium.org>, gojun077@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 2, 2019 at 3:02 PM <yhchuang@realtek.com> wrote:
> From: Yu-Yen Ting <steventing@realtek.com>
>
> MSI interrupt should be enabled on certain platform.
>
> Add a module parameter disable_msi to disable MSI interrupt,
> driver will then use legacy interrupt instead.
>
> One could rebind the PCI device, probe() will pick up the
> new value of the module parameter. Such as:
>
>     echo '0000:01:00.0' > /sys/bus/pci/drivers/rtw_pci/unbind
>     echo '0000:01:00.0' > /sys/bus/pci/drivers/rtw_pci/bind
>
> Tested-by: J=C3=A1n Vesel=C3=BD <jano.vesely@gmail.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Daniel Drake <drake@endlessm.com>
> Signed-off-by: Yu-Yen Ting <steventing@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>