Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 179CC601D4
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc:     devicetree@vger.kernel.org,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 31/49] ath11k: add mac.c
References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org>
        <1566316095-27507-32-git-send-email-kvalo@codeaurora.org>
        <4076919b34cad119eb4146025f587285ef40e37c.camel@sipsolutions.net>
        <ee38dc5e80097d0ebc186f81b2f11d37@codeaurora.org>
        <878sr3nfz8.fsf@kamboji.qca.qualcomm.com>
        <8e90a557c1659995d117c6dc8b728d7f@codeaurora.org>
Date:   Thu, 05 Sep 2019 15:29:40 +0300
In-Reply-To: <8e90a557c1659995d117c6dc8b728d7f@codeaurora.org> (Vasanthakumar
        Thiagarajan's message of "Thu, 05 Sep 2019 17:28:53 +0530")
Message-ID: <87woenkjt7.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> writes:

> On 2019-09-05 16:54, Kalle Valo wrote:
>> Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> writes:
>>
>>> On 2019-08-21 02:16, Johannes Berg wrote:
>>>> On Tue, 2019-08-20 at 18:47 +0300, Kalle Valo wrote:
>>>>
>>>>> +static int ath11k_mac_op_config(struct ieee80211_hw *hw, u32
>>>>> changed)
>>>>> +{
>>>>> +	struct ath11k *ar = hw->priv;
>>>>> +	int ret = 0;
>>>>> +
>>>>> +	/* mac80211 requires this op to be present and that's why
>>>>> +	 * there's an empty function, this can be extended when
>>>>> +	 * required.
>>>>> +	 */
>>>>
>>>> Well, oops. Maybe it shouldn't be required?
>>>
>>> I think we require this for some configuration handling. The comment
>>> is to be updated with proper information. We'll address that.
>>
>> The way I'm understanding Johannes' comment is that maybe we should
>> change mac80211 to require this op to be present. Should be easy to fix
>> in mac80211, right?
>
> Ok. So make this callback optional in mac80211? should be a simple
> code change.

Yeah, I was supposed to write:

"maybe we should change mac80211 to not require this op to be present"

But of course I could have just misunderstood, let's see what Johannes
says :)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches