Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1126009ybe; Fri, 6 Sep 2019 12:14:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqywUYWg4NYT+cMKFUucV9gZcalJDkvZEuScE7xD8axe3iDaVLU343ecO+z99U9zl17v0+Z6 X-Received: by 2002:a17:902:44c:: with SMTP id 70mr10665651ple.225.1567797283450; Fri, 06 Sep 2019 12:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567797283; cv=none; d=google.com; s=arc-20160816; b=TwdzfOYuTGz5HWSMn1vZEgIhOVn2ecE93cW0ALsKm5h3n6kl4hJi9yqDXyPDP5Zqab lZs8nR93w0gRQIC9lzWVE0NDgp6x0tRpD0GrCewMQ8+7Ag1LMD1gCqeWw3ADfs/STabk Jgf73tqTAn+qCX0geNKVnr911RJTCjwJmidaNNS0b2KeiuT45MR4GtRe1a4E4TkYhd0W IxpjsbSYSEHa2sKeHs4BgG1e3aehwgiUwNYPI6CpfEVGfTwN5jVP8pUnCmRitf6uiaVT V6q7WBJbDj2nl1L+8aRiSsKyIZHKKtDHg1qmHlFxbmPGDPcz1F0lOvzzP72/qqgB+E1m a/sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=jFzY21AimVmtJeEGHSzKG9j1AGusbIwTtWz4YIHJQSs=; b=W2ExxOWhC9Rt4Ag+tg01aT77uVqmypolnVRyfuE5JGGnJiO5gaHwUkmJPiluO3VLn3 GKauc1W3DaBM2e3v0Va4zM//6TvnT81qiV3u+Hy+OGso/XfWwYySw7i5dChDzMS+6D6B Mf8dYSlOQf5tYmjER2Dex/t7qFQVoFaWvKPwtqo4ZGrrhkihKA12POAZqWrh5aDKEkaq kv2xRTEZaIFtN2Zsgr3oT8RjcNOIZqkuF2DVoQPFg68zeT0+pjU5ELFdYrBO7WmkSIW/ 4G692qYnqwa4eE0/EEgjoLf+9cKgdQL+eRwTu4RDr65jxZCyrLV+/kyE5YMuu4JpOALF U9qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="PB/QzTq4"; dkim=pass header.i=@codeaurora.org header.s=default header.b=hnssT2yw; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si5061580pgr.277.2019.09.06.12.14.29; Fri, 06 Sep 2019 12:14:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="PB/QzTq4"; dkim=pass header.i=@codeaurora.org header.s=default header.b=hnssT2yw; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404463AbfIFOKy (ORCPT + 99 others); Fri, 6 Sep 2019 10:10:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45000 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728978AbfIFOKx (ORCPT ); Fri, 6 Sep 2019 10:10:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0C1346115A; Fri, 6 Sep 2019 14:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779053; bh=pZrUubcES+XghCJoDqpsjKdHbbqNAWcea7tZv+3cJls=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=PB/QzTq4vvnoX6Ec08VgumK/NnLndObCoK/SP7fODDhk+sZVv003IEVCVWyQTqbUE KtLs8oPTj7k/14GeD/m0c74sF5PzLdGUTldcWfOBaLn1n3bzAwMmH6iyNmnHF98wVd 36ywf3ytQD3nhK8INWpvLMWiy3zWjjBf++Y/xPO0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 88E1760770; Fri, 6 Sep 2019 14:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779052; bh=pZrUubcES+XghCJoDqpsjKdHbbqNAWcea7tZv+3cJls=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=hnssT2ywZ8Zee38Uk+I6TrEaVUE0ioMAujTXsXuBYJqM9159Z1NtNWJm75iZbz5pD TpQ5lrNxY8cQPSndyXx/QPyqy3xTNduh1DY6HWnpEnjPFpdfQ76YclZIrb4qO6ZnGV WP4klE3Sg4hK+fhOScfp8Qvci7auySvHpUdTED/8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 88E1760770 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: fix seq_file memory leak From: Kalle Valo In-Reply-To: <20190904141601.186107-1-weiyongjun1@huawei.com> References: <20190904141601.186107-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: Yan-Hsuan Chuang , Wei Yongjun , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190906141053.0C1346115A@smtp.codeaurora.org> Date: Fri, 6 Sep 2019 14:10:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wei Yongjun wrote: > When using single_open(), single_release() should be used instead > of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") > Signed-off-by: Wei Yongjun Patch applied to wireless-drivers-next.git, thanks. eb9affaeff70 rtw88: fix seq_file memory leak -- https://patchwork.kernel.org/patch/11130355/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches