Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1126111ybe; Fri, 6 Sep 2019 12:14:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwik/Yw8zJhFKgD6mnIUJyx85HbiGil3lx+xJ0uYj8DlGRFLGOamQDGTK4ItQAmUtg5Au5P X-Received: by 2002:a63:dd17:: with SMTP id t23mr9283237pgg.295.1567797290006; Fri, 06 Sep 2019 12:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567797289; cv=none; d=google.com; s=arc-20160816; b=L0eOsMBHS3olr+YN2fdeFMp8lZE13TQs+/P10sSQ0K4r2YtMM1O+jurMX4G55nedLl Fjj1EUIsMVWfMOiAadezfChi+fRP57yfv0Jik25VsgtK2446r6TVEDw7iihF8iXIGUEm yTyneuLJpOTHRewJ6ZmPvR3ygKiqSsiL1acTkMndh+Glj+oS5Y/ZwU7LtIliCUN/YBH4 oPvHMu505pgPzD0GVkHLPg+ylYcadsK47JLkfCb1SNtxXxV5l+Xcx9r2RwJOdlhrJthM Gn1GM4MzLU8W/CHmD50YruNHnCPPyphlx1ejNRxtSFG44cBKVeI+mjBeN71oq78Y/jqI P9Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=rMU/9jn7ayZ49R2l2M4MJG1c69ZEEtQeY+YH5Xi8lh0=; b=O4HIYh9meMikUpLqiozA90OGqSHuQJa3S5WI56bX9bzd0rX4iJaGUXDSaLNral06wG rweLeWIOZKhTvy/Q7pUZNSdZvv+beW9V9HPd+Gd4+mUdQvVgyzf/lDeelTHRWInxNxFz ZXGpc5US0W9B2mKHHmPWphVTlhTIC8uC7I5tzVRu+vlylzgBGc3bYA/32UfJ1NfDAEKE lt4Gq0oY0tr/9N/z1l3YHmTUvBSp2KemloFxvGISGOaBGb8RfgpLFoe8B0jFtTImA8tK oqiPtYu90lVkX+Ix4uyTxuTkQm+VzR+R11OmX7coTs0nCCNsCaXcxvFmjcKbLRsZBpSj 9low== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=HJLSFNKP; dkim=pass header.i=@codeaurora.org header.s=default header.b=cYuShNFD; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si6578387pfc.257.2019.09.06.12.14.35; Fri, 06 Sep 2019 12:14:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=HJLSFNKP; dkim=pass header.i=@codeaurora.org header.s=default header.b=cYuShNFD; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404581AbfIFOLz (ORCPT + 99 others); Fri, 6 Sep 2019 10:11:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46738 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731109AbfIFOLy (ORCPT ); Fri, 6 Sep 2019 10:11:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CF5606118D; Fri, 6 Sep 2019 14:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779113; bh=87O41lyZfEnUjjdEeuKeDT+ml8txqow14NjWrIcm7qw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=HJLSFNKPdmvw04PKT7kHon9Y8doTz5Hq188H5U8Ks61nGyl+bNixDY1vd8YXXWXdt 9zIha18A5/8Q5QEOtfcx4zOw5dz957c9pmq15Mmj12aL2Wzyn8RcworXW11kchrTwC 69DASwnhgmgvcD2pkWetU2mss8CXnZ/2uossVBcg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2651D6030B; Fri, 6 Sep 2019 14:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779113; bh=87O41lyZfEnUjjdEeuKeDT+ml8txqow14NjWrIcm7qw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=cYuShNFDgyOE4CfRJJK9cR7fjS1j8XJ/Wy/F9Z2fpl/bPY9MaTAADQIJKS3AHGvV8 VxliY0v8PGyJ+BeDj2kDity11tLVMBCZSjzLoKktGE32inYfLB3DTD3hd330hutVV3 L/ya+yadH3feCK/xoFY50hQnbkFCtEfzzauuHJ9M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2651D6030B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: Fix file release memory leak From: Kalle Valo In-Reply-To: <20190904141611.4780-1-weiyongjun1@huawei.com> References: <20190904141611.4780-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: Ping-Ke Shih , Wei Yongjun , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190906141153.CF5606118D@smtp.codeaurora.org> Date: Fri, 6 Sep 2019 14:11:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wei Yongjun wrote: > When using single_open() for opening, single_release() should be > used instead of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") > Signed-off-by: Wei Yongjun Patch applied to wireless-drivers-next.git, thanks. 4c3e48794dec rtlwifi: Fix file release memory leak -- https://patchwork.kernel.org/patch/11130357/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches