Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3038350ybe; Sun, 8 Sep 2019 05:58:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxaTncr17A5XC5vTaha31iPN0C6Xhm0S6v1rLmbeTvIcD9bMUuOm5NtJv1sl1/2GtA9KzMi X-Received: by 2002:a17:906:b88f:: with SMTP id hb15mr15184525ejb.292.1567947494869; Sun, 08 Sep 2019 05:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567947494; cv=none; d=google.com; s=arc-20160816; b=aKJGdzMymN7xSfb2PQQ68WCl/+lMGu6yLMVCba8/t35q88f9Cr7eRM2wLVftJDfBzv yzxrFxDGaRnEcfLJHjlsInKRyFT3dh+Mgl5yJRkY43JpMLm8SBArwqAsxUBHPPDlvZPU MzSt3Y9t3VBLArPHJe5E0nEJqyJ//DSdz1vtwiez9CEgq3F8RkEndXG9YGnA1uhcRPMn Uy9qkBW7+syXWf3xLVyP6qHNCIXUY4fpkBZj7LUyzdh9c9iiLPxy4bveEFERqDv9OpBU Zn5fC5Dct+s/pvkvTd/fDYcvVy5EfyZZeYVyj9LpO6MgqvtOxq/j/DuLjZYeoASV4qsm 8SSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=iJRvJgZCgmlYaYzQQakJAEuTdJCN8/cYe3UaA3uYtx4=; b=SreVukbkq4QFouyuDPw/M3yJzC4Hi54tbKuf98B9Rhe4o+8t1IJPyghprBZzHgx0o6 K0fUZQeDPpeEMlZOo47alkOxRJE3wkdq59DtB0Yve2VdfttjyZiWLBllKTV6Z4KkxCkT vT4jZparMdQnTxT4uvsEK3MDiV5X4RZ4QwxNqseCiHNKcNqXgVKfr19n1Ur94gw8GIpA hL4ALSspem9s+0lhaDOfnvgS0bqIs1tz4fHUpoTJMctHCJ9C8kv5f4s2Ol+JqkrogMGF YLf+8Bbe+RJBVq/QzwUgqU+VUlhNH7au7sGi3LSdAIaLx4nh5w5+NOZrO/aCYDuBkgPm HiDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si7086492edc.93.2019.09.08.05.57.50; Sun, 08 Sep 2019 05:58:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727402AbfIHIjP (ORCPT + 99 others); Sun, 8 Sep 2019 04:39:15 -0400 Received: from alexa-out-ams-02.qualcomm.com ([185.23.61.163]:7549 "EHLO alexa-out-ams-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbfIHIjO (ORCPT ); Sun, 8 Sep 2019 04:39:14 -0400 Received: from ironmsg03-ams.qualcomm.com ([10.251.56.4]) by alexa-out-ams-02.qualcomm.com with ESMTP; 08 Sep 2019 10:33:04 +0200 Received: from lx-merez1.mea.qualcomm.com ([10.18.173.103]) by ironmsg03-ams.qualcomm.com with ESMTP; 08 Sep 2019 10:33:03 +0200 From: Maya Erez To: Kalle Valo Cc: Dedy Lansky , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, Maya Erez Subject: [PATCH 07/11] wil6210: properly initialize discovery_expired_work Date: Sun, 8 Sep 2019 11:32:51 +0300 Message-Id: <1567931575-27984-8-git-send-email-merez@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1567931575-27984-1-git-send-email-merez@codeaurora.org> References: <1567931575-27984-1-git-send-email-merez@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Dedy Lansky Upon driver rmmod, cancel_work_sync() can be invoked on p2p.discovery_expired_work before this work struct was initialized. This causes a WARN_ON with newer kernel version. Add initialization of discovery_expired_work inside wil_vif_init(). Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/wil6210/netdev.c b/drivers/net/wireless/ath/wil6210/netdev.c index a2eca54..a87bb84 100644 --- a/drivers/net/wireless/ath/wil6210/netdev.c +++ b/drivers/net/wireless/ath/wil6210/netdev.c @@ -284,6 +284,7 @@ static void wil_vif_init(struct wil6210_vif *vif) INIT_WORK(&vif->probe_client_worker, wil_probe_client_worker); INIT_WORK(&vif->disconnect_worker, wil_disconnect_worker); + INIT_WORK(&vif->p2p.discovery_expired_work, wil_p2p_listen_expired); INIT_WORK(&vif->p2p.delayed_listen_work, wil_p2p_delayed_listen_work); INIT_WORK(&vif->enable_tx_key_worker, wil_enable_tx_key_worker); -- 1.9.1