Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DD4CF602BC
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath10k:  Free beacon buf later in vdev teardown.
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20190227162756.13048-1-greearb@candelatech.com>
References: <20190227162756.13048-1-greearb@candelatech.com>
To:     greearb@candelatech.com
Cc:     linux-wireless@vger.kernel.org,
        Ben Greear <greearb@candelatech.com>
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-Id: <20190910131244.1343F6050D@smtp.codeaurora.org>
Date:   Tue, 10 Sep 2019 13:12:44 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

greearb@candelatech.com wrote:

> My wave-1 firmware often crashes when I am bringing down
> AP vdevs, and sometimes at least some machines lockup hard
> after spewing IOMMU errors.
> 
> I don't see the same issue in STA mode, so I suspect beacons
> are the issue.
> 
> Moving the beacon buf deletion to later in the vdev teardown
> logic appears to help this problem.  Firmware still crashes
> often, but several iterations did not show IOMMU errors and
> machine didn't hang.

I'm not really fond of fixing issues just by luck but after a quick look at the
code I can't see any harm in this change either. So I guess it's ok.

But can you provide the exact hardware and firmware you used for testing, I'll
add it to the commit log. I want to document that in every commit:

https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines

Please also CC ath10k list when submitting patches.

-- 
https://patchwork.kernel.org/patch/10831867/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches