Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp934596ybe; Fri, 13 Sep 2019 08:33:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlP7UppJYYx2ePnawx2k6QPkuPxc/rB2eg08d7q8siMf4iE/ReczdHkiFizn4aQ6Xsewd5 X-Received: by 2002:a17:906:a851:: with SMTP id dx17mr40312874ejb.116.1568388820587; Fri, 13 Sep 2019 08:33:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568388820; cv=none; d=google.com; s=arc-20160816; b=CiNxu22SOL0JMw9F9ugeO/r6kcgl7fdgb6IK1H6uTkOI5LUOFnJja8Kshm30dz1Urv tgdjmJ+cxtRFauDC+iNnACGvtUfVcTmHbQ8irTbhX+DA+ZyXt4twdbPxcl5ZKsDn7JrE QdXHkqUcuzxlwMnYH5pimxTyJZwgipTPfnietWEqCEAd29ljzxH1GXWkFsiVEyIjzoc6 kNJ0IEtbjX6Xno8YtGjEDOqYY3YEp8nDc/2lXscvxNKjj8fB28ar6CVplC8WAFocCpDz Yw7HmoSaexGlN5n60UCRczlwo+n7qwnrGw9SOiOZX2wHuX68PPTXvlELLA3ACTqz3scH rBAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=dBBV1QMGms2CKfW30GNAYbA+TZPG5CuK1FDepcnp994=; b=g95A05eePO8/oKSnB8VJ0zOOTgIk+rHPcPON/50hheLynzfNyGncvZIrmjaWAAytQP 2H2TN/VKmufUOALPchDBujJcY/hKoZrXEJQRmJkh4HLGQRs/lkd4wOnKaemKi1RllACR 7FZZQFUt5WvImDyOV7V7M0K53L3tfPuDd/UgFD0OqARlFv4oGO3UgLrcs9i07I13BpW1 NdAWybAm5UDZD3SHalWF/RYbiLN5ocKR90z4pBlF/01neESF6/kqF5OMvia8hiav82Ie ggFpR73n27PJt1erMeC0I+pRa5KfJfiSJeS7JM7MjBVNvh9P3ITGAASfo6/xSTDVO1ul mKZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=O47+liZe; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jlm9fbzU; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16si17799221edb.420.2019.09.13.08.33.06; Fri, 13 Sep 2019 08:33:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=O47+liZe; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jlm9fbzU; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730378AbfIMOXh (ORCPT + 99 others); Fri, 13 Sep 2019 10:23:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42734 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbfIMOXg (ORCPT ); Fri, 13 Sep 2019 10:23:36 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C25DF607F1; Fri, 13 Sep 2019 14:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568384615; bh=zWlfvzD0O5IBrdDw1HOpbbjEiZ8kkIkXWCZbeIhl/U4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=O47+liZeya1C/CrzL3K0ZaidYHOi8U2XU3wG5qYYrObcm11hxJFNkbpwa57lAE8Ca A0MXwPjqKr5OhilBSJli5w6f7KaIwRRrPePDXGJI+a3Hwhl5BySuigqFs2gZ7gLrYY CAHNQN5cU6Gurvyh9Nw3KHgFLS2/a0beqBA867AQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CD91760769; Fri, 13 Sep 2019 14:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568384615; bh=zWlfvzD0O5IBrdDw1HOpbbjEiZ8kkIkXWCZbeIhl/U4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Jlm9fbzUEHDDsoJtyC+3fOOBQnXB+kCtUffKNOvsyx92KQUaNZvB4Y2VNDH04JH3z EQNrpyMWG0smO65fC5ilEsp/0bnE8ZnLvLhOJi6XZ3CCk/gY3nFHHDUUWNobInUsjo Lt33+tknuOdlMn8VyhL+ZV9Zi7P2q61Ix6Mj50Bo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CD91760769 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller From: Kalle Valo In-Reply-To: <20190906154053.32218-1-colin.king@canonical.com> References: <20190906154053.32218-1-colin.king@canonical.com> To: Colin King Cc: Michael Buesch , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190913142335.C25DF607F1@smtp.codeaurora.org> Date: Fri, 13 Sep 2019 14:23:35 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Don't populate the array pwr_info_offset on the stack but instead make it > static const. Makes the object code smaller by 207 bytes. > > Before: > text data bss dec hex filename > 26066 3000 64 29130 71ca drivers/ssb/pci.o > > After: > text data bss dec hex filename > 25763 3096 64 28923 70fb drivers/ssb/pci.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King > Acked-by: Michael Büsch Patch applied to wireless-drivers-next.git, thanks. d3bb26868105 ssb: make array pwr_info_offset static const, makes object smaller -- https://patchwork.kernel.org/patch/11135599/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches